Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateDrawableProperties is dead code #721

Open
adroitwhiz opened this issue Nov 9, 2020 · 0 comments · May be fixed by #722
Open

updateDrawableProperties is dead code #721

adroitwhiz opened this issue Nov 9, 2020 · 0 comments · May be fixed by #722
Labels
tech debt

Comments

@adroitwhiz
Copy link
Contributor

Expected Behavior

There should not be dead code in the codebase

Actual Behavior

The updateDrawableProperties function has been completely phased out. #469 added individual update functions for each property, and scratchfoundation/scratch-vm#2329 removed the last of the calls to updateDrawableProperties, replacing them with the new update functions.

As such, updateDrawableProperties is no longer called anywhere and can be removed.
@adroitwhiz adroitwhiz linked a pull request Nov 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove updateDrawableProperties adroitwhiz/scratch-render
2 participants
@BryceLTaylor @adroitwhiz