-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: New built-in action to create Freshdesk tickets #357
Comments
If we start to add new external systems like this and #356 I think we should discuss how we should do it?
|
I think this is the right approach to take whenever possible. If that worse case scenario happens, and it would not be weird, we can then decide how to approach the issue: deprecate the feature on our end, or revive and maintain that dependency. However, we might want to keep this integration stuff out of the Spidermon repository. I am not sure how easy it would be with the current Spidermon codebase, but I think having separate packages for integration with different third-party services, in line with https://github.com/scrapy-plugins, would make Spidermon maintenance easier on the long run. |
For actions like this, it should be very straightforward to create a separated repository with just the integrations we need. It is basically one class that needs to be imported and used. Even the existing integrations (like Telegram, Discord, AWS SES) could be removed. The source code of each plugin will be small and probably very stable requiring low maintenance. Perhaps we could create new repositories over https://github.com/scrapy-plugins (which could make sense as it is Scrapy-related) or a new organization like https://github.com/spidermon-plugins, so we can have things like:
Related to this comment, we could change how we install Spidermon, so if we use Any thoughts? |
For separate packages, I would keep them out of extras, let people install them separately, that should be it. But extras for those components that are in the repository at the moment I think extras make sense. |
At the moment built-in actions focus on supporting different alert systems. It would be nice to support ticketing systems by default, as automatically reporting issues based on Spidermon alerts is a common feature across many client projects.
The text was updated successfully, but these errors were encountered: