Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemProvider always requires Response #150

Closed
kmike opened this issue Jun 8, 2023 · 2 comments
Closed

ItemProvider always requires Response #150

kmike opened this issue Jun 8, 2023 · 2 comments
Assignees
@Gallaecio

Comments

@kmike
Copy link
Member

kmike commented Jun 8, 2023

Currently ItemProvider always requires Response. So, if a page object doesn't need a response, and an item produced by this page object is used as a dependency, then Response is still downloaded.
@kmike kmike mentioned this issue Jun 8, 2023
Merged
@wRAR
Copy link
Member

wRAR commented Jun 12, 2023 •
edited
Loading

As ItemProvider only needs a Response object to pass it to build_instances() we discussed the idea that just passing a DummyResponse instance there can be enough but didn't check that.

@Gallaecio Gallaecio self-assigned this Jun 15, 2023
@Gallaecio Gallaecio mentioned this issue Jun 15, 2023
Closed
@Gallaecio
Copy link
Member

Resolved by #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gallaecio Gallaecio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ItemProvider’s Response dependency scrapinghub/scrapy-poet
3 participants
@kmike @wRAR @Gallaecio