Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coverageAggregate with parameter #393

Open
Chmieeel opened this issue Nov 5, 2021 · 3 comments
Open

Run coverageAggregate with parameter #393

Chmieeel opened this issue Nov 5, 2021 · 3 comments

Comments

@Chmieeel
Copy link

Chmieeel commented Nov 5, 2021

Currently, the plugin allows you to add the minimumCoverage field and inform whether the minimum has been reached. To do this, you need to put the % value in the minimumCoverage variable in the build.sbt file.

Can we skip the sbt file?? I mean run coverageAggregate with a parameter

@ckipp01
Copy link
Member

ckipp01 commented Nov 5, 2021

Hello! Thanks for the questions! So scoverage doesn't technically need a coverage set. You can still run the aggregate task and by default it will just tell you the %. So when you say:

I mean run coverageAggregate with a parameter

How would you be running this? With sbt coverageAggregate? And you would just want to pass the % in?

@Chmieeel
Copy link
Author

Chmieeel commented Nov 5, 2021

Actual if you want to have minimum coverage value you need put value to variable in sbt file.

I would like to run it like the example below

sbt coverageAggregate 20.34 or sbt coverageAggregate minimumCoverage=20.34

@ckipp01
Copy link
Member

ckipp01 commented Nov 5, 2021

I would like to run it like the example below

sbt coverageAggregate 20.34 or sbt coverageAggregate minimumCoverage=20.34

Understood, this currently isn't supported and I'm not sure it's something I'd like to add as typically you'd want this reproducibly locally and and CI. I'll leave this open in case others have thoughts on this, but for now I don't plan on implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants