Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize launching of CoreAgent binary #37

Closed
cschneid opened this issue Aug 21, 2019 · 1 comment
Closed

Optimize launching of CoreAgent binary #37

cschneid opened this issue Aug 21, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@cschneid
Copy link
Contributor

Currently we attempt to connect, then if that fails, launch the binary. But that means we have to open the connection on every request, and that if the binary fails launching, we'll continually attempt to spawn it causing overhead.

A likely approach is to use the new extension to hold a persistent socket open, rather than attempting to manage it solely from PHP code.
@asgrim
Copy link
Collaborator

asgrim commented Sep 13, 2019

see also: scoutapp/scout-apm-php-ext#25

@asgrim asgrim added duplicate This issue or pull request already exists enhancement New feature or request labels Nov 5, 2019
@asgrim asgrim closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cschneid @asgrim