Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DerivedSource::architecture could return 'unknown' #120

Open
asgrim opened this issue Nov 27, 2019 · 3 comments
Open

DerivedSource::architecture could return 'unknown' #120

asgrim opened this issue Nov 27, 2019 · 3 comments
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 27, 2019

Currently, \Scoutapm\Config\Source\DerivedSource::architecture could return unknown if php_uname('m') returns anything other than i686 or x86_64.

Question: should we throw an exception, since we don't support the architecture?

@asgrim asgrim added enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement question Further information is requested labels Nov 27, 2019
@asgrim
Copy link
Collaborator Author

asgrim commented Nov 27, 2019

@cschneid please advise? I think probably just throwing a hard exception here seems sensible?

@cschneid
Copy link
Contributor

Either a hard exception, or just default to i686 and see if it works? I'm not sure of the scope of the values that can come out of the arch call.

At some point, I could see us adding ARM or similar, but nobody has requested it yet.

@asgrim asgrim removed the question Further information is requested label Dec 3, 2019
@asgrim asgrim assigned asgrim and unassigned cschneid and asgrim Dec 3, 2019
@iWader
Copy link

iWader commented Jun 28, 2021

Logging a clear error message or exception would be ideal, currently a 404 error is logged due to the unknown-unknown-linux-musl tarball not existing and it isn't immediately obviously why. We deployed scout onto some ec2 t4g instances today and it failed to work, despite the extension appearing to install via pecl fine

It does fail gracefully when failing the download, so throwing an exception would be a bc

I guess this is me asking for ARM support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have This is a "nice to have" feature - not a critical requirement
Projects
None yet
Development

No branches or pull requests

3 participants