Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word diffs #12

Open
scottgonzalez opened this issue Jan 31, 2014 · 3 comments
Open

Word diffs #12

scottgonzalez opened this issue Jan 31, 2014 · 3 comments

Comments

@scottgonzalez
Copy link
Owner

There's already a branch for this, but I can't figure out good logic for determining what a "word" is. Looking into the logic used for git instaweb might provide some insight.

@jzaefferer
Copy link
Contributor

👍 for this feature.

I'm not sure how git instaweb helps, that seems to be mostly a bash script that integrates various web servers: https://github.com/git/git/blob/398dd4bd039680ba98497fbedffa415a43583c16/git-instaweb.sh

I've looked around for any details or even open source projects from GitHub's implementation. The closest I could find is this blog post, but that mostly talks about split view diffs: http://markdotto.com/2014/09/04/shipping-githubs-split-diffs/

I've asked the author if there are any plans to open source something: https://twitter.com/bassistance/status/577811088269565952

Maybe one day this will find results: https://github.com/github?query=diff

@jzaefferer
Copy link
Contributor

One more thing, for QUnit we're looking into using Google's diff-patch-match library (at least parts of it): qunitjs/qunit#772 - not sure if that would help here though.

@scottgonzalez
Copy link
Owner Author

I don't really want to stray from using git diff as that means I'd either have to drop support for all of the existing functionality or re-implement it myself. So using diff-patch-match isn't an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants