Merge remote-tracking branch 'origin/v92-bugfix' into v9-minor

Author: svigerske

CHANGELOG

@@ -58,6 +58,8 @@ Build system
 Miscellaneous
 -------------
 
+- when writing a problem with non-generic names, warnings are printed if variable or constraint names are not unique
+
 @section RN922 SCIP 9.2.2
 *************************
 

src/scip/reader.c

@@ -271,6 +271,7 @@ SCIP_RETCODE SCIPreaderWrite(
    SCIP_READER*          reader,             /**< reader */
    SCIP_PROB*            prob,               /**< problem data */
    SCIP_SET*             set,                /**< global SCIP settings */
+   SCIP_MESSAGEHDLR*     msghdlr,            /**< message handler */
    FILE*                 file,               /**< output file (or NULL for standard output) */
    const char*           extension,          /**< file format */
    SCIP_Bool             genericnames,       /**< using generic variable and constraint names? */
@@ -302,12 +303,52 @@ SCIP_RETCODE SCIPreaderWrite(
       int nconss;
       int nvars;
       int i;
+      int nduplicates;
 
       vars = SCIPprobGetVars(prob);
       nvars = SCIPprobGetNVars(prob);
       fixedvars = SCIPprobGetFixedVars(prob);
       nfixedvars = SCIPprobGetNFixedVars(prob);
 
+      /* check if multiple variables have the same name */
+      if ( !genericnames )
+      {
+         nduplicates = 0;
+
+         for( i = 0; i < nvars; ++i )
+         {
+            if( vars[i] != (SCIP_VAR*) SCIPprobFindVar(prob, (void*) SCIPvarGetName(vars[i])) )
+            {
+               if( nduplicates < 3 )
+               {
+                  SCIPmessageFPrintWarning(msghdlr, "The same variable name <%s> has been used for at least two different variables.\n", SCIPvarGetName(vars[i]));
+               }
+               ++nduplicates;
+            }
+         }
+
+         for( i = 0; i < nfixedvars; ++i )
+         {
+            if( fixedvars[i] != (SCIP_VAR*) SCIPprobFindVar(prob, (void*) SCIPvarGetName(fixedvars[i])) )
+            {
+               if( nduplicates < 3 )
+               {
+                  SCIPmessageFPrintWarning(msghdlr, "The same variable name <%s> has been used for at least two different variables.\n", SCIPvarGetName(fixedvars[i]));
+               }
+               ++nduplicates;
+            }
+         }
+
+         if( nduplicates > 0 )
+         {
+            if( nduplicates > 3 )
+            {
+               SCIPmessageFPrintWarning(msghdlr, "In total %d duplicate variable names.\n", nduplicates);
+            }
+            SCIPmessageFPrintWarning(msghdlr, "This will likely result in wrong output files. Please use unique variable names.\n");
+         }
+      }
+
       /* case of the transformed problem, we want to write currently valid problem */
       if( SCIPprobIsTransformed(prob) )
       {
@@ -369,6 +410,33 @@ SCIP_RETCODE SCIPreaderWrite(
          nconss = SCIPprobGetNConss(prob);
       }
 
+      /* check if multiple constraints have the same name */
+      if ( !genericnames )
+      {
+         nduplicates = 0;
+
+         for( i = 0; i < SCIPprobGetNConss(prob); ++i )
+         {
+            if( conss[i] != (SCIP_CONS*) SCIPprobFindCons(prob, (void*) SCIPconsGetName(conss[i])) )
+            {
+               if( nduplicates < 3 )
+               {
+                  SCIPmessageFPrintWarning(msghdlr, "The same constraint name <%s> has been used for at least two different constraints.\n", SCIPconsGetName(conss[i]));
+               }
+               ++nduplicates;
+            }
+         }
+
+         if( nduplicates > 0)
+         {
+            if( nduplicates > 3 )
+            {
+               SCIPmessageFPrintWarning(msghdlr, "In total %d duplicate constraint names.\n", nduplicates);
+            }
+            SCIPmessageFPrintWarning(msghdlr, "This can result in wrong output files, especially with indicator constraints.\n");
+         }
+      }
+
       if( genericnames )
       {
          SCIP_VAR* var;

src/scip/reader.h

@@ -87,6 +87,7 @@ SCIP_RETCODE SCIPreaderWrite(
    SCIP_READER*          reader,             /**< reader */
    SCIP_PROB*            prob,               /**< problem data */
    SCIP_SET*             set,                /**< global SCIP settings */
+   SCIP_MESSAGEHDLR*     msghdlr,            /**< message handler */
    FILE*                 file,               /**< output file (or NULL for standard output) */
    const char*           format,             /**< file format (or NULL) */
    SCIP_Bool             genericnames,       /**< using generic variable and constraint names? */

src/scip/scip_solvingstats.c

@@ -2319,9 +2319,9 @@ SCIP_RETCODE printProblem(
       SCIP_RETCODE retcode;
 
       if( extension != NULL )
-         retcode = SCIPreaderWrite(scip->set->readers[i], prob, scip->set, file, extension, genericnames, &result);
+         retcode = SCIPreaderWrite(scip->set->readers[i], prob, scip->set, scip->messagehdlr, file, extension, genericnames, &result);
       else
-         retcode = SCIPreaderWrite(scip->set->readers[i], prob, scip->set, file, "cip", genericnames, &result);
+         retcode = SCIPreaderWrite(scip->set->readers[i], prob, scip->set, scip->messagehdlr, file, "cip", genericnames, &result);
 
       /* check for reader errors */
       if( retcode == SCIP_WRITEERROR )