You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh, was not expecting the pull request to be merged without sparking any discussion.
I am a bit busy currently to implement this , but maybe, just to get an idea of the scope, I have a few questions:
What is the purpose of clone_for_plugin? From my understanding it is used in callbacks to query model information, e.g. during branching.
Is it needed? I think, as of now, it suffers from the same problems as in segfault (use after free) when accessing solution after model is dropped #138 (By accessing the clone after the main model is dropped). I think it might be better just to remove it all together. If someone wants a shallow-copy(or a reference), the user can either choose to use a reference (&Model) or a reference-counting pointer (Rc<Model> & Arc<Model>).
Would it be fine to remove it (given that I fix the tests)? It would be an API breaking change :/, and some users might not love it.
Originally posted by @Andful in #149 (comment)
The text was updated successfully, but these errors were encountered: