Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - Add score to GeneralizedLinearEstimator based on its datafit #254

Open
mathurinm opened this issue May 31, 2024 · 0 comments
Open

Comments

@mathurinm
Copy link
Collaborator

A datafit can implement a score (based on its use for classif or regression) and this score can be accessed by GeneralizedLinearEstimator.score()

This would be one more step towards sklearn-like behavior

I think this should be done with Mixins:

  • define ClassificationDatafitMixin, RegressionDatafitMixin that have their own score()
  • All datafits inherit from one or the other
  • GeneralizedLinearModel.score calls self.datafit.score()

As a cherry on top this would enable us to replace the hardcoded isclassif in _glm_fit, that currently checks if a datafit is for classif by checking if it's equal to Logistic or QuadraticSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant