Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PKLM] - Qolmat implementation #155

Open
3 of 8 tasks
adriencrtr opened this issue Aug 2, 2024 · 1 comment
Open
3 of 8 tasks

[PKLM] - Qolmat implementation #155

adriencrtr opened this issue Aug 2, 2024 · 1 comment
Assignees
@adriencrtr
Labels
enhancement New feature or request

Comments

@adriencrtr
Copy link
Collaborator

adriencrtr commented Aug 2, 2024 •
edited
Loading

Following the pklm exploration, implement the PKLM test in Qolmat.

  • Design of the MCARTest Class
  • Implement the methods
  • Tests
  • Random_state usage
  • compute_exact_p_value
  • One_hot_encoding
  • Documentation
  • Tutorial
@adriencrtr adriencrtr added the enhancement New feature or request label Aug 2, 2024
@adriencrtr adriencrtr self-assigned this Aug 2, 2024
@adriencrtr
Copy link
Collaborator Author

I am blocked on those points :

  • not able to set the random_state for reproductibility
  • On the technical point the "exact p_value computing" is OK but I am not able to reproduce the results according to the Jeffrey's advices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriencrtr adriencrtr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

pklm-implementation scikit-learn-contrib/qolmat
1 participant
@adriencrtr