Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows build_sdist to dereference links #943

Open
atuleu opened this issue Nov 7, 2024 · 1 comment
Open

Allows build_sdist to dereference links #943

atuleu opened this issue Nov 7, 2024 · 1 comment

Comments

@atuleu
Copy link

atuleu commented Nov 7, 2024

Currently the sdist step simply copy all symlinks even if they are pointing outside of the build tree.

It would be nice to add an option to force sdist to dereference all links when building the tarball.

A working proof of concept could be found here: main...atuleu:scikit-build-core:main

Would you accept such nre option?, should I open a PR?

@LecrisUT
Copy link
Collaborator

LecrisUT commented Nov 7, 2024

See #801. In principal 👍 for this feature. But could you also resolve the linked issue, i.e. if the symlink points outside the sdist root (iiuc it's the folder that contains pyproject.toml) then de-reference it. That should already be there, but it seems that it only applies to files. Ideally for Linux packagers the default of keeping symlinks should be preserved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants