Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating [pyproject] optional-dependency #882

Open
LecrisUT opened this issue Aug 30, 2024 · 6 comments
Open

Deprecating [pyproject] optional-dependency #882

LecrisUT opened this issue Aug 30, 2024 · 6 comments

Comments

@LecrisUT
Copy link
Collaborator

Since pyproject is effectively an empty optional-dependency, should it be deprecated and removed eventually? I'm not sure how to query the dependencies on PyPI, but for Fedora there are a couple that would nee patching:

$ fedrq wr python3-scikit-build-core+pyproject
python-cascadio-0.0.13-1.fc41.src
python-llama-cpp-python-0.2.75-6.fc41.src
@henryiii
Copy link
Collaborator

henryiii commented Sep 3, 2024

It's there for a while since it pip will produce a warning if users request it and it's not there. But I think we can remove it soon or maybe even next release.

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Sep 3, 2024

Unfortunately users probably ignore warnings until the last second. 72 hits that I was able to find: https://sourcegraph.com/search?q=context:global+scikit-build-core%5B&patternType=keyword&sm=0

@henryiii
Copy link
Collaborator

What's the "last second"? Unless pip makes this an error, it's always been a warning to request an extra that doesn't exist. And we can't add a warning any other way.

@LecrisUT
Copy link
Collaborator Author

Well since this is only observed at the build time, they would only see it in the CI, which they would generally be ignoring, until the optional dependency is actually removed causing errors. I will probably add -Werror to my various CI builds as well after thinking about this.

@henryiii
Copy link
Collaborator

henryiii commented Sep 10, 2024

optional dependency is actually removed causing errors

That's the point, removing the optional dependency causes warnings, not errors.

. I will probably add -Werror to my various CI builds as well after thinking about this.

This is a pip warning, not a Python warning. (Though, that's a really good idea in general, and recommended at https://learn.scientific-python.org/development/guides/pytest/#configuring-pytest).

@henryiii
Copy link
Collaborator

See scikit-build-core[color], for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants