Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App susceptible to scrypt DOS via login form #585

Open
brassy-endomorph opened this issue Sep 14, 2024 · 0 comments
Open

App susceptible to scrypt DOS via login form #585

brassy-endomorph opened this issue Sep 14, 2024 · 0 comments

Comments

@brassy-endomorph
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The app is susceptible to DOS via scrypt by allowing arbitrary length input on the LoginForm.

class LoginForm(FlaskForm):
username = StringField("Username", validators=[DataRequired()])
password = PasswordField("Password", validators=[DataRequired()])

Describe the solution you'd like

We should have a limit on that. And since this has potential to lock users out of their accounts if we ever change the password max length, we should have some sort of test to ensure that the limit doesn't tighten if we change the registration password length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant