Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Method should be its own DB field, not prepended to submitted messages #583

Open
brassy-endomorph opened this issue Sep 13, 2024 · 2 comments

Comments

@brassy-endomorph
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We currently concatenated the contact method and message content before storing it in the database:

hushline/hushline/routes.py

Lines 214 to 218 in 53c65ee

content = form.content.data
contact_method = form.contact_method.data.strip() if form.contact_method.data else ""
full_content = (
f"Contact Method: {contact_method}\n\n{content}" if contact_method else content
)

Describe the solution you'd like

This should be a separate field so that we can better display them to the recipient. This will also later allow for better i18n.

@brassy-endomorph
Copy link
Collaborator Author

Relates to #514

@glenn-sorrentino
Copy link
Member

Downside of this is that we (currently) only PGP encrypt messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: BL-P6 - Code & Doc Enhancements
Development

No branches or pull requests

2 participants