-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move most of the parameters for queryTrips in new TripOptions class #214
Comments
Sounds good to me, except |
Okay, so we would leave |
I'm a bit indifferent to |
While I think this change would be an improvement, I don't think it is worth to break the API without a strong argument. Making it prettier isn't a strong argument that would justify the re-factoring required for the consumers of the library. Maybe the old API can continue to exist and get deprecated, but converted to the new format?
I'd leave via out of the options and instead leave it between from and to. |
I'm fine with keeping a deprecated old version of the method. |
Fixed with #216. |
This is just a follow up on #102 (comment) to discuss the idea.
I've had a quick look which of the parameters could be moved into a new
TripOptions
class. I would leavefrom
,to
anddate
as normal parameters, while moving all the others into the new class (dep
,products
,optimize
,walkSpeed
,accessibility
,options
) because they seem quite "auxiliary". Would you be ok with this distribution @schildbach ?The text was updated successfully, but these errors were encountered: