Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function schema_wp_amp_modify_json_output shows a Warning #31

Open
eduardoarandah opened this issue Dec 3, 2018 · 0 comments
Open

Function schema_wp_amp_modify_json_output shows a Warning #31

eduardoarandah opened this issue Dec 3, 2018 · 0 comments

Comments

@eduardoarandah
Copy link

When displaying an amp page I get a warning:

Warning: in_array() expects parameter 2 to be array, null given in /.../public/wp-content/plugins/schema/includes/integrations/amp.php on line 32

Insted of:
if (array($options['supported_post_types']) ...

I guess it should be:
if (isset($options['supported_post_types']) ...

But I see it's already fixed:
https://github.com/schemapress/Schema/blob/master/includes/integrations/amp.php

May I suggest tagging your versions? So we can contribute to specific versions.
check this example: https://github.com/roots/sage/releases

Bug found in:
Schema Version: 1.7.2
AMP Plugin:

AMP Version 0.7.2
By WordPress.com VIP, XWP, Google, and contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eduardoarandah