Questions around <Threshold> tag for db linter

[bheemreddy181-zz]

Schema Crawler Config Used

<schemacrawler-linter-configs>
  <linter id="io.github.mbarre.schemacrawler.tool.linter.LinterTimeStampWithOutTimeZoneColumn">
    <run>true</run>
    <severity>critical</severity>
    <threshold>807</threshold>
  </linter>
  <linter id="schemacrawler.tools.linter.LinterTableWithNoPrimaryKey">
    <run>true</run>
    <severity>critical</severity>
    <threshold>175</threshold>
  </linter>
</schemacrawler-linter-configs>

With the above threshold in place, I assume I should see the linter to show all failures but the overall job to be passed with the threshold, I feel the threshold tag works the same as exclude-columns

Linter command used :

schemacrawler -server=postgresql -database=cnuapp_int -user=postgres -password='' -linterconfigs=schemacrawler-linter-configs.xml -c=lint -lintdispatch=terminate_system -runalllinters=false

CI run looks like below

Expecting to see the CI run more like below but with an exit code 0

Would like to hear your thoughts @sualeh

[sualeh]

@bheemreddy181 - I want to see if the threshold is working. Please make both thresholds 10, and try again. Then make them both 3000 and try again. Please let me know what happens.

Also, I will only be supporting SchemaCrawler 16.15.2. Please use the latest version of SchemaCrawler, so I can help you debug your issues. (Note that the command-line switches have changed from what you are using.)

[bheemreddy181-zz]

@sualeh I did try the way you mentioned above here are the results

when the <threshold>10<threshold> it still fails

when the <threshold>3000<threshold> it's a Success

[sualeh]

Success meaning error code of 0?

[bheemreddy181-zz]

Yes @sualeh

[bheemreddy181-zz]

What is so significant about these two numbers? ( i.e 10 and 50 )

[sualeh]

Nothing really. Trying to understand what is happening, and how I can reproduce it.

[sualeh]

@bheemreddy181 - I tried, but I could not reproduce your issue. I think what you will have to do is use the latest version of SchemaCrawler, and try to reproduce. If the issue persists, we may have to do a screen share to see what is going on.

[bheemreddy181-zz]

Ah sorry - you are correct - exit codes were different - for some reason, I read them wrong last time - i could see exit code 0 for 935 vs exit code 1 for 934. Working as expected and config is getting read correctly.

[sualeh]

Perfect. Issue resolved.

[bheemreddy181-zz]

will wait for Additional lints to be updated and test there too.

[sualeh]

The way to distinguish them is you will get a message saying "Too many schema lints were found" in the logs. This message will be logged at a different severity level based on the type of dispatch.

[sualeh]

Ok. You can now mark this discussion as answered, so we can close it out.