Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable tombstone function name #5

Closed
4 tasks done
scheb opened this issue Aug 6, 2020 · 1 comment
Closed
4 tasks done

Configurable tombstone function name #5

scheb opened this issue Aug 6, 2020 · 1 comment

Comments

@scheb
Copy link
Owner

scheb commented Aug 6, 2020

Idea

Currently the tombstone function name is hardcoded to tombstone (a function within the global scope). Make that function configurable and allow having multiple tombstone functions. Multiple tombstone functions would provide more flexibility, e.g.

  • You don't want a function in the global scope, but use something namespaced instead
  • Have a function that always logs invocations vs. have a function that randomly logs (sampling)
  • Use different tombstones for different purposes

If this idea would be useful to you, give it a +1

Todo

  • Add function name to Tombstone class
  • Log tombstone function name
  • Add analyzer config option for tombstone functions names, pass these to the extractor
  • Add analyzer config option to use tombstone function name for matching tombstones (or not, to treat all tombstone functions as if they're all the same function)
@scheb scheb added this to the 1.0 milestone Aug 11, 2020
scheb added a commit that referenced this issue Aug 11, 2020
@scheb scheb removed this from the 1.0 milestone Aug 12, 2020
@scheb
Copy link
Owner Author

scheb commented Dec 29, 2020

Feature released with v1.3.0.

@scheb scheb closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant