Checking correct method exists #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating assertDirectoryDoesNotExist to test for the correct method when using old version of phpunit
|
Thanks for fixing that! Must have copy & pasted that and missed to change the method. Wondering why that ever worked 🙈 because in fact there is a CI-build against 7.1 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updating assertDirectoryDoesNotExist to test for the correct method when using the old version of PHPUnit
There is an issue with the test
ensureDirectoryCreated_directoryAlreadyCreated_doNothingit fails when using PHP 7.2, The base classTestCasewhich extends PHPUnit to help with backward compatibility is incorrect. The methodassertDirectoryDoesNotExistis checking forexpectExceptionMessageMatchesnot it's self.Suggestion
As this package supports PHP 7.1 and great maybe all versions should be tested in the CI?
closes #26