Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing duration condition in line 179 is not reached. #210

Open
neuromechanist opened this issue Apr 24, 2024 · 0 comments
Open

Missing duration condition in line 179 is not reached. #210

neuromechanist opened this issue Apr 24, 2024 · 0 comments

Comments

@neuromechanist
Copy link
Member

When all events in a task do not have a duration ("instantaneous" events or onsets/offsets), it might be best to remove the EEG.event.duration field and then have n/a for all rows in BIDS _events.tsv.

The following line should be modified to implement this feature:
https://github.com/sccn/bids-matlab-tools/blob/b53c87f624373f1c0bc02b85278a4c888e38a7be/bids_writeeventfile.m#L112

The second condition should be removed. The line should looklike:

        if ~any(strcmp(bids_fields,'duration')), opt.eInfo(end+1,:) = { 'duration' 'duration' }; end

Then the code would put n/a for duration:

https://github.com/sccn/bids-matlab-tools/blob/b53c87f624373f1c0bc02b85278a4c888e38a7be/bids_writeeventfile.m#L179-L183

I tested this feature in RC3 of the HBN dataset: /home/sshirazi/yahya/cmi_bids_R3_RC3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant