From 1d6b39222cee025cfb0786b7597faba7045b657b Mon Sep 17 00:00:00 2001 From: jremy Date: Wed, 3 Jul 2024 15:21:15 +0200 Subject: [PATCH 1/2] fix invalid memory address in backup --- internal/namespaces/rdb/v1/custom_backup.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/internal/namespaces/rdb/v1/custom_backup.go b/internal/namespaces/rdb/v1/custom_backup.go index 1cb67c3dec..937d1c4163 100644 --- a/internal/namespaces/rdb/v1/custom_backup.go +++ b/internal/namespaces/rdb/v1/custom_backup.go @@ -288,6 +288,7 @@ func backupDownloadCommand() *core.Command { Timeout: scw.TimeDurationPtr(backupActionTimeout), RetryInterval: core.DefaultRetryInterval, } + backup, err := api.WaitForDatabaseBackup(backupRequest) if err != nil { return nil, err @@ -320,6 +321,11 @@ func backupDownloadCommand() *core.Command { } httpClient := core.ExtractHTTPClient(ctx) + + if backup.DownloadURL == nil { + return nil, fmt.Errorf("Download URL is still nil after export") + } + res, err := httpClient.Get(*backup.DownloadURL) if err != nil { return nil, err From f1911cd82973219e6d1eac9479b8c5ab79c83fac Mon Sep 17 00:00:00 2001 From: jremy Date: Wed, 3 Jul 2024 15:53:26 +0200 Subject: [PATCH 2/2] fix lint --- internal/namespaces/rdb/v1/custom_backup.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/namespaces/rdb/v1/custom_backup.go b/internal/namespaces/rdb/v1/custom_backup.go index 937d1c4163..391997e7a9 100644 --- a/internal/namespaces/rdb/v1/custom_backup.go +++ b/internal/namespaces/rdb/v1/custom_backup.go @@ -323,7 +323,7 @@ func backupDownloadCommand() *core.Command { httpClient := core.ExtractHTTPClient(ctx) if backup.DownloadURL == nil { - return nil, fmt.Errorf("Download URL is still nil after export") + return nil, fmt.Errorf("download URL is still nil after export") } res, err := httpClient.Get(*backup.DownloadURL)