Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comma-separted namespace options #27

Open
choplin opened this issue Aug 30, 2023 · 1 comment
Open

Allow comma-separted namespace options #27

choplin opened this issue Aug 30, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request schema-importer

Comments

@choplin
Copy link
Collaborator

choplin commented Aug 30, 2023

Description

Currently, schema-importer accepts multiple --namespace options to specify multiple namespaces, like below.

$ schema-importer --namespace ns1 --namespace --ns2

However, other Scalar tools employ a comma-separated style to specify multiple options.

$ schema-importer --namespace ns1,ns2

To keep consistency among the products, we should also allow a comma-separated style for schema-importer.

Considerations

  • Should we keep multiple options after implementing a comma-separated style or obsolete it?
  • Should be the name of the comma-separated style option --namespace as well?
@choplin choplin added enhancement New feature or request schema-importer labels Aug 30, 2023
@choplin choplin self-assigned this Aug 30, 2023
@kota2and3kan
Copy link
Contributor

Thank you for considering this improvement!

Should we keep multiple options after implementing a comma-separated style or obsolete it?

I will create the Helm Chart based on the current implementation (i.e., multiple options). So, I want schema-importer to keep multiple options in v3.x.

However, I think it's OK if it obsoletes multiple options in v4.x in the future (i.e., the backward incompatible update is acceptable in a major release).

Should be the name of the comma-separated style option --namespace as well?

I think there is no problem if we use the same name.
However, this is a very minor thing, but it might be better to use --namespaces (plural form) because this option can accept several namespaces.


FYI:

The following configurations related to the namespace in other ScalarDB tools adopt the comma-separated style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schema-importer
Projects
None yet
Development

No branches or pull requests

2 participants