add parentheses to all non-arg java methods

Author: rochala

presentation-compiler/src/main/dotty/tools/pc/CompilerSearchVisitor.scala

@@ -17,7 +17,7 @@ class CompilerSearchVisitor(
 )(using ctx: Context, reports: ReportContext)
     extends SymbolSearchVisitor:
 
-  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName.nn).nn
+  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName().nn).nn
 
   private def isAccessible(sym: Symbol): Boolean = try
     sym != NoSymbol && sym.isPublic && sym.isStatic

presentation-compiler/src/main/dotty/tools/pc/CompletionItemResolver.scala

@@ -60,7 +60,7 @@ object CompletionItemResolver extends ItemResolver:
       else ""
     val companion = gsym.companion
     if companion == NoSymbol || gsym.is(JavaDefined) then
-      if gsymDoc.isEmpty then
+      if gsymDoc.isEmpty() then
         if gsym.isAliasType then
           fullDocstring(gsym.info.metalsDealias.typeSymbol, search)
         else if gsym.is(Method) then
@@ -73,8 +73,8 @@ object CompletionItemResolver extends ItemResolver:
       else gsymDoc
     else
       val companionDoc = docs(companion)
-      if companionDoc.isEmpty then gsymDoc
-      else if gsymDoc.isEmpty then companionDoc
+      if companionDoc.isEmpty() then gsymDoc
+      else if gsymDoc.isEmpty() then companionDoc
       else
         List(
           s"""|### ${keyword(companion)} ${companion.name}

presentation-compiler/src/main/dotty/tools/pc/HoverProvider.scala

@@ -78,7 +78,7 @@ object HoverProvider:
         )
       end report
       reportContext.unsanitized.create(report, ifVerbose = true)
-      ju.Optional.empty.nn
+      ju.Optional.empty().nn
     else
       val skipCheckOnName =
         !pos.isPoint // don't check isHoveringOnName for RangeHover
@@ -146,7 +146,7 @@ object HoverProvider:
                 )
               ).nn
             case _ =>
-              ju.Optional.empty.nn
+              ju.Optional.empty().nn
           end match
       end match
     end if
@@ -189,7 +189,7 @@ object HoverProvider:
 
       refTpe.flatMap(findRefinement).asJava
     case _ =>
-      ju.Optional.empty.nn
+      ju.Optional.empty().nn
 
 end HoverProvider
 

presentation-compiler/src/main/dotty/tools/pc/InferredTypeProvider.scala

@@ -67,7 +67,7 @@ final class InferredTypeProvider(
 
     val sourceText = adjustOpt.map(_.text).getOrElse(params.text.nn)
     val source =
-      SourceFile.virtual(filePath.toString, sourceText)
+      SourceFile.virtual(filePath.toString(), sourceText)
     driver.run(uri, source)
     val unit = driver.currentCtx.run.nn.units.head
     val pos = driver.sourcePosition(params)
@@ -308,7 +308,7 @@ final class InferredTypeProvider(
           val end = if withBacktick then idx + 1 else idx
           val pos = tree.source.atSpan(Span(start, end, start))
           Some(pos)
-        case None if idx < text.length =>
+        case None if idx < text.length() =>
           val ch = text.charAt(idx)
           if ch == realName.head then
             lookup(idx + 1, Some((idx, realName.tail)), withBacktick)

presentation-compiler/src/main/dotty/tools/pc/MetalsDriver.scala

@@ -48,7 +48,7 @@ class MetalsDriver(
 
   override def run(uri: URI, sourceCode: String): List[Diagnostic] =
     val diags =
-      if alreadyCompiled(uri, sourceCode.toCharArray.nn) then Nil
+      if alreadyCompiled(uri, sourceCode.toCharArray().nn) then Nil
       else super.run(uri, sourceCode)
     lastCompiledURI = uri
     diags

presentation-compiler/src/main/dotty/tools/pc/PcCollector.scala

@@ -37,7 +37,7 @@ abstract class PcCollector[T](
   val filePath = Paths.get(uri).nn
   val sourceText = params.text.nn
   val source =
-    SourceFile.virtual(filePath.toString, sourceText)
+    SourceFile.virtual(filePath.toString(), sourceText)
   driver.run(uri, source)
   given ctx: Context = driver.currentCtx
 

presentation-compiler/src/main/dotty/tools/pc/PcDefinitionProvider.scala

@@ -54,7 +54,7 @@ class PcDefinitionProvider(
       if findTypeDef then findTypeDefinitions(path, pos, indexedContext)
       else findDefinitions(path, pos, indexedContext)
 
-    if result.locations.nn.isEmpty then fallbackToUntyped(pos)(using ctx)
+    if result.locations.nn.isEmpty() then fallbackToUntyped(pos)(using ctx)
     else result
   end definitions
 

presentation-compiler/src/main/dotty/tools/pc/PcInlineValueProviderImpl.scala

@@ -27,7 +27,7 @@ final class PcInlineValueProviderImpl(
 ) extends PcCollector[Occurence](driver, params)
     with InlineValueProvider:
 
-  val text = params.text.nn.toCharArray.nn
+  val text = params.text.nn.toCharArray().nn
 
   val position: l.Position = pos.toLsp.getStart.nn
 

presentation-compiler/src/main/dotty/tools/pc/SemanticdbTextDocumentProvider.scala

@@ -29,7 +29,7 @@ class SemanticdbTextDocumentProvider(
     val validCode = removeMagicImports(sourceCode, filePath)
     driver.run(
       uri,
-      SourceFile.virtual(filePath.toString, validCode)
+      SourceFile.virtual(filePath.toString(), validCode)
     )
     val tree = driver.currentCtx.run.nn.units.head.tpdTree
     val extractor = ExtractSemanticDB.Extractor()
@@ -42,7 +42,7 @@ class SemanticdbTextDocumentProvider(
         if Properties.isWin then relativeUri.toString().replace("\\", "/")
         else relativeUri.toString()
       }
-      .getOrElse(filePath.toString)
+      .getOrElse(filePath.toString())
 
     val document = TextDocument(
       schema = Schema.SEMANTICDB4,
@@ -57,7 +57,7 @@ class SemanticdbTextDocumentProvider(
     val out = SemanticdbOutputStream.newInstance(byteStream)
     document.writeTo(out)
     out.flush()
-    byteStream.toByteArray.nn
+    byteStream.toByteArray().nn
   end textDocument
 
 end SemanticdbTextDocumentProvider

presentation-compiler/src/main/dotty/tools/pc/SignatureHelpProvider.scala

@@ -175,11 +175,11 @@ object SignatureHelpProvider:
     info
 
   private def markupContent(content: String): l.MarkupContent | Null =
-    if content.isEmpty then null
+    if content.isEmpty() then null
     else
       val markup = new l.MarkupContent
       markup.setKind("markdown")
-      markup.setValue(content.trim)
+      markup.setValue(content.trim())
       markup
 
 end SignatureHelpProvider

presentation-compiler/src/main/dotty/tools/pc/TastyUtils.scala

@@ -40,7 +40,7 @@ object TastyUtils:
   end htmlTasty
 
   private def tastyHtmlPageTitle(file: URI) =
-    val filename = Paths.get(file).nn.getFileName.toString
+    val filename = Paths.get(file).nn.getFileName().toString
     s"TASTy for $filename"
 
   private val standaloneHtmlStyles =

presentation-compiler/src/main/dotty/tools/pc/completions/AmmoniteFileCompletions.scala

@@ -63,32 +63,32 @@ object AmmoniteFileCompletions:
       )
 
     def matches(file: Path): Boolean =
-      (Files.isDirectory(file) || file.toAbsolutePath.toString.isAmmoniteScript) &&
-        query.exists(q => CompletionFuzzy.matches(q.nn, file.getFileName.toString))
+      (Files.isDirectory(file) || file.toAbsolutePath().toString.isAmmoniteScript) &&
+        query.exists(q => CompletionFuzzy.matches(q.nn, file.getFileName().toString))
 
     (split, workspace) match
       case (_ :: script :: Nil, Some(workspace)) =>
         // drop / or \
         val current = workspace.resolve(script.drop(1))
         val importPath = translateImportToPath(select).drop(1)
-        val currentPath = current.nn.getParent.nn.resolve(importPath).nn.toAbsolutePath
+        val currentPath = current.nn.getParent().nn.resolve(importPath).nn.toAbsolutePath()
         val parentTextEdit =
           if query.exists(_.nn.isEmpty()) &&
-            Files.exists(currentPath.nn.getParent) && Files.isDirectory(
+            Files.exists(currentPath.nn.getParent()) && Files.isDirectory(
               currentPath
             )
           then List(parent)
           else Nil
         Files
           .list(currentPath).nn
-          .iterator.nn
+          .iterator().nn
           .asScala
           .toList
-          .filter(path => !fileName.contains(path.nn.getFileName.toString.stripSuffix(".sc")))
+          .filter(path => !fileName.contains(path.nn.getFileName().toString.stripSuffix(".sc")))
           .collect {
             case file if matches(file) =>
               CompletionValue.FileSystemMember(
-                file.getFileName.toString,
+                file.getFileName().toString,
                 editRange,
                 isDirectory = Files.isDirectory(file)
               )

presentation-compiler/src/main/dotty/tools/pc/completions/AmmoniteIvyCompletions.scala

@@ -23,7 +23,7 @@ object AmmoniteIvyCompletions:
       case None => Nil
       case Some(dependency) =>
         val isInitialCompletion =
-          pos.lineContent.trim == "import $ivy."
+          pos.lineContent.trim() == "import $ivy."
         val ivyEditRange =
           if isInitialCompletion then completionPos.toEditRange
           else

presentation-compiler/src/main/dotty/tools/pc/completions/CompletionPos.scala

@@ -56,7 +56,7 @@ object CompletionPos:
     val prevIsDot =
       if start - 1 >= 0 then text.charAt(start - 1) == '.' else false
     val kind =
-      if query.nn.isEmpty && !prevIsDot then CompletionKind.Empty
+      if query.nn.isEmpty() && !prevIsDot then CompletionKind.Empty
       else if prevIsDot then CompletionKind.Members
       else CompletionKind.Scope
 
@@ -74,7 +74,7 @@ object CompletionPos:
   ): (Int, Boolean) =
     var i = 0
     var tabIndented = false
-    while lineOffset + i < text.length && {
+    while lineOffset + i < text.length() && {
         val char = text.charAt(lineOffset + i)
         if char == '\t' then
           tabIndented = true
@@ -126,7 +126,7 @@ object CompletionPos:
    */
   private def inferIdentEnd(pos: SourcePosition, text: String): Int =
     var i = pos.point
-    while i < text.length && Chars.isIdentifierPart(text.charAt(i)) do i += 1
+    while i < text.length() && Chars.isIdentifierPart(text.charAt(i)) do i += 1
     i
 
 end CompletionPos

presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala

@@ -87,7 +87,7 @@ class Completions(
     def hasSyntheticCursorSuffix: Boolean =
       if !sym.name.endsWith(Cursor.value) then false
       else
-        val realNameLength = sym.decodedName.length - Cursor.value.length
+        val realNameLength = sym.decodedName.length() - Cursor.value.length()
         sym.source == pos.source &&
         sym.span.start + realNameLength == pos.span.end
 
@@ -571,7 +571,7 @@ class Completions(
               val nameId =
                 if sym.isClass || sym.is(Module) then
                   // drop #|. at the end to avoid duplication
-                  name.substring(0, name.length - 1).nn
+                  name.substring(0, name.length() - 1).nn
                 else name
               val suffix =
                 if symOnly.snippetSuffix.addLabelSnippet then "[]" else ""
@@ -693,7 +693,7 @@ class Completions(
         if !ov.symbol.is(Deferred) then penalty |= MemberOrdering.IsNotAbstract
         penalty
       case CompletionValue.Workspace(_, sym, _, _) =>
-        symbolRelevance(sym) | (IsWorkspaceSymbol + sym.name.show.length)
+        symbolRelevance(sym) | (IsWorkspaceSymbol + sym.name.show.length())
       case sym: CompletionValue.Symbolic =>
         symbolRelevance(sym.symbol)
       case _ =>
@@ -782,7 +782,7 @@ class Completions(
       def fuzzyScore(o: CompletionValue.Symbolic): Int =
         fuzzyCache.getOrElseUpdate(
           o, {
-            val name = o.label.toLowerCase.nn
+            val name = o.label.toLowerCase().nn
             if name.startsWith(queryLower) then 0
             else if name.contains(queryLower) then 1
             else 2

presentation-compiler/src/main/dotty/tools/pc/completions/InterpolatorCompletions.scala

@@ -35,7 +35,7 @@ object InterpolatorCompletions:
       config: PresentationCompilerConfig,
       buildTargetIdentifier: String
   )(using Context, ReportContext) =
-    InterpolationSplice(pos.span.point, text.toCharArray.nn, text) match
+    InterpolationSplice(pos.span.point, text.toCharArray().nn, text) match
       case Some(interpolator) =>
         InterpolatorCompletions.contributeScope(
           text,

presentation-compiler/src/main/dotty/tools/pc/completions/KeywordsCompletions.scala

@@ -26,7 +26,7 @@ object KeywordsCompletions:
       checkIfNotInComment(completionPos.cursorPos, comments)
 
     path match
-      case Nil if completionPos.query.isEmpty =>
+      case Nil if completionPos.query.isEmpty() =>
         Keyword.all.collect {
           // topelevel definitions are allowed in Scala 3
           case kw if (kw.isPackage || kw.isTemplate) && notInComment =>

presentation-compiler/src/main/dotty/tools/pc/completions/OverrideCompletions.scala

@@ -175,7 +175,7 @@ object OverrideCompletions:
 
     val uri = params.uri.nn
     val text = params.text.nn
-    driver.run(uri, SourceFile.virtual(uri.toASCIIString.nn, text))
+    driver.run(uri, SourceFile.virtual(uri.toASCIIString().nn, text))
 
     val unit = driver.currentCtx.run.nn.units.headOption
     unit match

presentation-compiler/src/main/dotty/tools/pc/printer/ShortenedTypePrinter.scala

@@ -503,7 +503,7 @@ class ShortenedTypePrinter(
         if includeDefaultParam == ShortenedTypePrinter.IncludeDefaultParam.Include && isDefaultParam
         then
           val defaultValue = docInfo match
-            case Some(value) if !value.defaultValue.nn.isEmpty =>
+            case Some(value) if !value.defaultValue.nn.isEmpty() =>
               value.defaultValue()
             case _ => "..."
           s" = $defaultValue"

presentation-compiler/src/main/dotty/tools/pc/utils/MtagsEnrichments.scala

@@ -101,7 +101,7 @@ object MtagsEnrichments extends CommonMtagsEnrichments:
       for
         uri <- InteractiveDriver.toUriOption(pos.source)
         range <- if pos.exists then Some(pos.toLsp) else None
-      yield new l.Location(uri.toString, range)
+      yield new l.Location(uri.toString(), range)
 
     def encloses(other: SourcePosition): Boolean =
       pos.start <= other.start && pos.end >= other.end