Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #316

Closed
SethTisue opened this issue Nov 17, 2020 · 18 comments
Closed

Release 2.0.0 #316

SethTisue opened this issue Nov 17, 2020 · 18 comments

Comments

@SethTisue
Copy link
Member

@Philippus had you given this any thought...?

(thought prompted by #234)

@arashi01
Copy link

@Philippus, @SethTisue Any chance this can happen? (prompted by #270)

Ideally releasing against Dotty 3.0.0-M2 as well!

@SethTisue
Copy link
Member Author

Ideally releasing against Dotty 3.0.0-M2 as well!

I've opened a separate ticket for that: #334

This ticket can be about broader 1.2.0 planning

@SethTisue
Copy link
Member Author

Should it be 2.0.0, according to semantic versioning?

@SethTisue
Copy link
Member Author

1.2.0-M1 is published

@SethTisue
Copy link
Member Author

we're continuing to do 1.2.0-Mx releases as needed to support Scala 3 prereleases

in the absence of any other input or opinions about the future, I guess I'd be inclined to wait until Scala 3.0.0 final is released, then go 1.2.0-RC1 and then 1.2.0 final with whatever we have. there haven't been any complaints about the milestones

@Philippus
Copy link
Member

In light of scala/sbt-scala-module#111 I think we should also set a VersionScheme and make sure the next release complies with it. The next release will break binary compatibility.

@SethTisue
Copy link
Member Author

maybe it's better to go RC1 before Scala 3.0.0 final is released, as it seems unlikely that any further changes will land

@SethTisue
Copy link
Member Author

Scala 3.0.0-RC2 is out. I will release 1.2.0-RC1 today.

@SethTisue SethTisue mentioned this issue Mar 29, 2021
13 tasks
@SethTisue
Copy link
Member Author

1.2.0-RC1 is out

@SethTisue
Copy link
Member Author

SethTisue commented Apr 19, 2021

backpublished 1.2.0-RC1 for Scala 3.0.0-RC3

@xerial xerial mentioned this issue May 13, 2021
3 tasks
@xerial
Copy link

xerial commented May 13, 2021

I think @SethTisue will release 1.2.0 now that Scala 3.0.0 is released. As always, thank you!

@SethTisue
Copy link
Member Author

I'll try very hard to get to that today

@Philippus
Copy link
Member

Should we make it 2.0.0 ?

@SethTisue
Copy link
Member Author

Should we make it 2.0.0 ?

I'd asked that above, back in December, but I can't remember what my thinking was at the time. It should be 2.0 because we broke bincompat, is that right? (Sorry if we've been over this before, but I work in so many repos...)

@Philippus
Copy link
Member

Yeah, we removed scala.util.parsing.json for one, so that's quite a big change already.

@SethTisue SethTisue changed the title Release 1.2.0 Release 2.0.0 May 13, 2021
@SethTisue
Copy link
Member Author

Looks like the planning is done and just the publishing remains: #386

@xerial
Copy link

xerial commented May 14, 2021

@SethTisue Thanks for the release!

FYI. I found one issue with the major version change from 1.x to 2.x (e.g., sbt 1.5.x shows an error with dependency eviction twitter/util#287), but I think the time will resolve this type of issue. A workaround is adding a setting like:

ThisBuild / libraryDependencySchemes += "org.scala-lang.modules" %% "scala-parser-combinators" % "always"

@SethTisue
Copy link
Member Author

Yeah, I think that's as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants