Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows test jobs don't appear to be running JUnit tests #506

Closed
SethTisue opened this issue May 11, 2018 · 5 comments
Closed

Windows test jobs don't appear to be running JUnit tests #506

SethTisue opened this issue May 11, 2018 · 5 comments
Assignees
Labels

Comments

@SethTisue
Copy link
Member

at e.g. https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-windows/561/console I see the JUnit tests being compiled, but not actually being run

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-windows/977/consoleFull, same

2.11 seems okay at https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-integrate-windows/1004/consoleFull

if this is real, I should check ScalaCheck and other stuff too

@SethTisue SethTisue changed the title Windows test jobs doesn't appear to be running JUnit tests Windows test jobs don't appear to be running JUnit tests May 11, 2018
@SethTisue SethTisue self-assigned this May 11, 2018
@SethTisue
Copy link
Member Author

I wondered if this wasn't a Windows bug, but simply a bug in the testAll task, which we don't use in our other scripts. But when I run testAll locally (on MacOS anyway), the tests run. so idk

@SethTisue
Copy link
Member Author

SethTisue commented May 11, 2018

another hypothesis to check: are we running sbt at info level or warn level? because while messing with scala/scala#6621 I think I may have seen that with -warn, running (non-partest) tests may be silent. not sure, but note to self for later

@SethTisue
Copy link
Member Author

I think I may have seen that with -warn, running (non-partest) tests may be silent

you might expect to at least get a summary at the end saying how many tests ran, but actually:

> junit/test
# WARNING: Unable to attach Serviceability Agent. You can try again with escalated privileges. Two options: a) use -Djol.tryWithSudo=true to try with sudo; b) echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope
skipping mrJar() on old JdK
skipping mrJar() on old JDK
[success] Total time: 79 s, completed May 11, 2018 9:53:52 PM
> 

here I think the [success] at the end comes because the entire command finished, but with testAll you wouldn't get that after each part.

@SethTisue
Copy link
Member Author

yeah I'm confident now that's all this is. why scripts/jobs/integrate/windows even has --warn in it at all, I have no idea.

I'm going to close this and just make a note at #508 to probably increasing the logging level at the time we move to AppVeyor

/cc @martijnhoekstra

@martijnhoekstra
Copy link

Sounds likely - I still haven't been able to run the integrate/windows script locally (I probably need cygwin for it, and git decided again I need carriage returns in bash files, making it fail in spectacular ways on git bash and in LSW), but sbt testAll does what it should on Windows in all shells/environments I've tried and have available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants