Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load remote DTDs by default #7726

Closed
scabug opened this issue Aug 7, 2013 · 3 comments
Closed

Don't load remote DTDs by default #7726

scabug opened this issue Aug 7, 2013 · 3 comments

Comments

@scabug
Copy link

scabug commented Aug 7, 2013

A lot of people have trouble with parsing documents whose DTDs are unavailable or intentionally served by slow servers (e.g. http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic/) -- we should update the "obvious" parsing entry points so they'll avoid loading DTDs by default.

Ordinarily it would be user-friendly to deprecate an existing method and create a new one, but while there's one primary entry point (XMLLoader#loadXML), there are two sets of overloads (three loadFile and five load) and another loadString to contend with.

Personally, in this case I might be tempted to just flipping the default around completely to non-DTD, and make people use a custom SAXParser if they actually want validation. In one sense this is a non-disruptive change, since things that once failed will no longer fail, but of course in another sense it's the worst kind of change, since anyone who was relying on our default parser to do their DTD validation will now have a river of sludge flowing into their app.

Le sigh.

@scabug
Copy link
Author

scabug commented Aug 7, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7726?orig=1
Reporter: @acruise
Assignee: @acruise

@scabug
Copy link
Author

scabug commented Jul 17, 2015

@SethTisue said:
The scala-xml library is now community-maintained. Issues with it are now tracked at https://github.com/scala/scala-xml/issues instead of here in the Scala JIRA.

Interested community members: if you consider this issue significant, feel free to open a new issue for it on GitHub, with links in both directions.

@scabug scabug closed this as completed Jul 17, 2015
@scabug
Copy link
Author

scabug commented Feb 16, 2017

@SethTisue said:
this is now scala/scala-xml#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant