Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unmanagedSourceDirectories over unmanagedSources #26

Open
DomBlack opened this issue Jul 27, 2015 · 1 comment
Open

Comments

@DomBlack
Copy link

At the moment the plugin is based on unmanagedSources which defaults to *.scala and *.java only. However the plugin allows us to specify headers by extension.

I believe the better solution would be to modify the plugin to use the unmanagedSourceDirectories key and find all the matching files in those directories based on the headerSettings map passed in, rather than getting the user to both specify the extension in the map, and then update their includeFilter in (Compile, unmanagedSources ) to include custom extensions too.

This is useful when dealing with plugins which use different file formats, but still can take copyright headers (such as .proto files and .txt files for i18n)

@saeta
Copy link

saeta commented May 22, 2016

@hseeberger If I were to make a PR that implemented this, would it be merged in & a new release published? Or should we fork this project? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants