Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untracked files in source directory result in a version without SNAPSHOT suffix #176

Open
otopetrik opened this issue Dec 1, 2019 · 0 comments

Comments

@otopetrik
Copy link

Creating a new file (and not adding it to git) results in a version without SNAPSHOT suffix.

uncommittedSignifier (SNAPSHOT,dirty, etc...) is not applied if the only change is the creation of new files. Without adding them to git, they are not considered uncommitted changes:

override def hasUncommittedChanges: Boolean = porcelain.status.call.hasUncommittedChanges

from hasUncommittedChanges documentation: "true if any tracked file is changed"

Running a build in a directory containing non-tracked files should result in SNAPSHOT suffix (or at least it should be configurable). The sources used for such build do not match sources committed in the repository.

jgitver-maven-plugin uses !status.isClean(), rather than hasUncommitedChanges.

isClean considers untracked files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant