Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete bans with exploited names #373

Open
shavitush opened this issue Dec 1, 2017 · 0 comments
Open

Can't delete bans with exploited names #373

shavitush opened this issue Dec 1, 2017 · 0 comments
Assignees
Labels
semver: patch template: used Issue is written in the issue template type: bug

Comments

@shavitush
Copy link
Contributor

shavitush commented Dec 1, 2017

Exploited names cannot have their bans deleted/unbanned.

Expected Behavior

Having the ability to unban every banned player.

Current Behavior

Cannot unban the exploited name user:

<!-- a legit player's ban -->
<a href="#" onclick="RemoveBan('18133', '?????????????????', '', 'Lost', 0, false);return false;" target="_self"><img src="images/delete.png" alt="" style="vertical-align:middle" border="0"> Delete Ban </a>

<!-- an exploited name's ban -->
<a href="#" onclick="RemoveBan('18135', '?????????????????', '', '// heaven.gg - 
', 0, false);return false;" target="_self"><img src="images/delete.png" alt="" style="vertical-align:middle" border="0"> Delete Ban </a>

Possible Solution

Escape special characters in names? (or even add it into StripQuotes)

function StripQuotes($str)
{
    $str = str_replace("'", "", $str);
    $str = str_replace('"', "", $str);
    return $str;
}

to

function StripQuotes($str)
{
    $str = str_replace("'", "", $str);
    $str = str_replace('"', "", $str);
    $str = trim(preg_replace('/\s+/', ' ', $str));
    return $str;
}

Steps to Reproduce (for bugs)

No clue. It requires a cheat in-game. Possibly \n in a name?

Your Environment

@Groruk Groruk added the template: used Issue is written in the issue template label Apr 14, 2018
@Groruk Groruk self-assigned this Oct 1, 2019
@Hackmastr Hackmastr added this to 1.7.0 Jun 2, 2024
@Hackmastr Hackmastr moved this to To do in 1.7.0 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch template: used Issue is written in the issue template type: bug
Projects
Status: To do
Development

No branches or pull requests

3 participants