BREAKING CHANGE: Remove submit_code and test_code keymap, use replace by toggle.

Author: saying121

CHANGELOG.md

@@ -6,6 +6,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Added
+
+- Use `toggle` trigger submit and test code.
+
+### Changed
+
+- Remove `submit_code` and `test_code` keymap, use replace by `toggle`.
+
 ## [0.8.1] - 2024-04-28
 
 ### Fixed

completions/_lcode

@@ -337,7 +337,7 @@ esac
 _lcode_commands() {
     local commands; commands=(
 'edit:Edit \`code\` or \`test cases\`, \[ alias\: e \]' \
-'fzy:Interact select a question (fuzzy search), default view detail \[ alias\: f \]' \
+'fzy:Interact select a question (fuzzy search), \[ alias\: f \]' \
 'detail:View a question detail \[ alias\: D \]' \
 'sync:Syncanhronize leetcode info \[ alias\: S \]' \
 'test:Test your code \[ alias\: t \]' \
@@ -493,7 +493,7 @@ _lcode__fzy__help__help_commands() {
 _lcode__help_commands() {
     local commands; commands=(
 'edit:Edit \`code\` or \`test cases\`, \[ alias\: e \]' \
-'fzy:Interact select a question (fuzzy search), default view detail \[ alias\: f \]' \
+'fzy:Interact select a question (fuzzy search), \[ alias\: f \]' \
 'detail:View a question detail \[ alias\: D \]' \
 'sync:Syncanhronize leetcode info \[ alias\: S \]' \
 'test:Test your code \[ alias\: t \]' \

completions/lcode.bash

@@ -191,7 +191,7 @@ _lcode() {
             return 0
             ;;
         lcode__edit)
-            opts="-h --help <INPUT> code test help"
+            opts="-h --help <ID> code test help"
             if [[ ${cur} == -* || ${COMP_CWORD} -eq 2 ]] ; then
                 COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
                 return 0
@@ -205,7 +205,7 @@ _lcode() {
             return 0
             ;;
         lcode__edit__code)
-            opts="-h --help <INPUT>"
+            opts="-h --help <ID>"
             if [[ ${cur} == -* || ${COMP_CWORD} -eq 3 ]] ; then
                 COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
                 return 0
@@ -275,7 +275,7 @@ _lcode() {
             return 0
             ;;
         lcode__edit__test)
-            opts="-h --help <INPUT>"
+            opts="-h --help <ID>"
             if [[ ${cur} == -* || ${COMP_CWORD} -eq 3 ]] ; then
                 COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
                 return 0

completions/lcode.fish

@@ -1,8 +1,8 @@
 complete -c lcode -n "__fish_use_subcommand" -l generate -r -f -a "{bash	'',elvish	'',fish	'',powershell	'',zsh	''}"
 complete -c lcode -n "__fish_use_subcommand" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_use_subcommand" -s V -l version -d 'Print version'
-complete -c lcode -n "__fish_use_subcommand" -f -a "edit" -d 'Edit `code` or `test cases`, default edit `code` [ alias: e ]'
-complete -c lcode -n "__fish_use_subcommand" -f -a "fzy" -d 'Interact select a question (fuzzy search), default view detail [ alias: f ]'
+complete -c lcode -n "__fish_use_subcommand" -f -a "edit" -d 'Edit `code` or `test cases`, [ alias: e ]'
+complete -c lcode -n "__fish_use_subcommand" -f -a "fzy" -d 'Interact select a question (fuzzy search), [ alias: f ]'
 complete -c lcode -n "__fish_use_subcommand" -f -a "detail" -d 'View a question detail [ alias: D ]'
 complete -c lcode -n "__fish_use_subcommand" -f -a "sync" -d 'Syncanhronize leetcode info [ alias: S ]'
 complete -c lcode -n "__fish_use_subcommand" -f -a "test" -d 'Test your code [ alias: t ]'
@@ -24,13 +24,13 @@ complete -c lcode -n "__fish_seen_subcommand_from edit; and __fish_seen_subcomma
 complete -c lcode -n "__fish_seen_subcommand_from edit; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from code; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from help" -f -a "test" -d 'Edit test case'
 complete -c lcode -n "__fish_seen_subcommand_from edit; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from code; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from help" -f -a "help" -d 'Print this message or the help of the given subcommand(s)'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -s h -l help -d 'Print help'
-complete -c lcode -n "__fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "detail" -d 'View detail'
+complete -c lcode -n "__fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "detail" -d 'View detail(default)'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "edit" -d 'Edit code'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "help" -d 'Print this message or the help of the given subcommand(s)'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from detail" -s f -l force -d 'Force update question\'s information'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from detail" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from edit" -s h -l help -d 'Print help'
-complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "detail" -d 'View detail'
+complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "detail" -d 'View detail(default)'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "edit" -d 'Edit code'
 complete -c lcode -n "__fish_seen_subcommand_from fzy; and __fish_seen_subcommand_from help; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from help" -f -a "help" -d 'Print this message or the help of the given subcommand(s)'
 complete -c lcode -n "__fish_seen_subcommand_from detail" -s f -l force -d 'Force update question\'s information'
@@ -40,14 +40,14 @@ complete -c lcode -n "__fish_seen_subcommand_from sync" -s h -l help -d 'Print h
 complete -c lcode -n "__fish_seen_subcommand_from test" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from submit" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from sublist" -s h -l help -d 'Print help'
-complete -c lcode -n "__fish_seen_subcommand_from gencon" -s c -l cn
+complete -c lcode -n "__fish_seen_subcommand_from gencon" -s c -l cn -d 'Generate cn config'
 complete -c lcode -n "__fish_seen_subcommand_from gencon" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from tui" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from config" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from log" -s h -l help -d 'Print help'
 complete -c lcode -n "__fish_seen_subcommand_from star" -s h -l help -d 'Print help'
-complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "edit" -d 'Edit `code` or `test cases`, default edit `code` [ alias: e ]'
-complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "fzy" -d 'Interact select a question (fuzzy search), default view detail [ alias: f ]'
+complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "edit" -d 'Edit `code` or `test cases`, [ alias: e ]'
+complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "fzy" -d 'Interact select a question (fuzzy search), [ alias: f ]'
 complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "detail" -d 'View a question detail [ alias: D ]'
 complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "sync" -d 'Syncanhronize leetcode info [ alias: S ]'
 complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "test" -d 'Test your code [ alias: t ]'
@@ -61,5 +61,5 @@ complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subc
 complete -c lcode -n "__fish_seen_subcommand_from help; and not __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from sync; and not __fish_seen_subcommand_from test; and not __fish_seen_subcommand_from submit; and not __fish_seen_subcommand_from sublist; and not __fish_seen_subcommand_from gencon; and not __fish_seen_subcommand_from tui; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from log; and not __fish_seen_subcommand_from star; and not __fish_seen_subcommand_from help" -f -a "help" -d 'Print this message or the help of the given subcommand(s)'
 complete -c lcode -n "__fish_seen_subcommand_from help; and __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from code; and not __fish_seen_subcommand_from test" -f -a "code" -d 'Edit code(default)'
 complete -c lcode -n "__fish_seen_subcommand_from help; and __fish_seen_subcommand_from edit; and not __fish_seen_subcommand_from code; and not __fish_seen_subcommand_from test" -f -a "test" -d 'Edit test case'
-complete -c lcode -n "__fish_seen_subcommand_from help; and __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit" -f -a "detail" -d 'View detail'
+complete -c lcode -n "__fish_seen_subcommand_from help; and __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit" -f -a "detail" -d 'View detail(default)'
 complete -c lcode -n "__fish_seen_subcommand_from help; and __fish_seen_subcommand_from fzy; and not __fish_seen_subcommand_from detail; and not __fish_seen_subcommand_from edit" -f -a "edit" -d 'Edit code'

crates/lcode-config/src/keymap.rs

@@ -30,8 +30,6 @@ pub const TOGGLE_SUBMIT_RES: &str = "toggle_submit_res";
 pub const TOGGLE_TEST_RES: &str = "toggle_test_res";
 pub const TOGGLE_MENU: &str = "toggle_menu";
 
-pub const TEST_CODE: &str = "test_code";
-pub const SUBMIT_CODE: &str = "submit_code";
 pub const RE_QS_DETAIL: &str = "re_get_qs";
 pub const NEXT_TAB: &str = "next_tab";
 pub const PREV_TAB: &str = "prev_tab";
@@ -216,16 +214,6 @@ impl Default for TuiKeyMap {
                 desc:   "re get question detail (reference tab0/select cursor question info)"
                     .to_owned(),
             },
-            KeyMap {
-                keys:   Keys(vec![Key::new(SHIFT, KeyCode::Char('S'))]),
-                action: SUBMIT_CODE.to_owned(),
-                desc:   "submit this question code to leetcode (in edit show menu)".to_owned(),
-            },
-            KeyMap {
-                keys:   Keys(vec![Key::new(SHIFT, KeyCode::Char('T'))]),
-                action: TEST_CODE.to_owned(),
-                desc:   "test this question code to leetcode (in edit show menu)".to_owned(),
-            },
             KeyMap {
                 keys:   Keys(vec![Key::new(CTRL, KeyCode::Char('t'))]),
                 action: TOGGLE_TEST_RES.to_owned(),
@@ -239,7 +227,9 @@ impl Default for TuiKeyMap {
             KeyMap {
                 keys:   Keys(vec![Key::new(NO_CONTROL, KeyCode::Enter)]),
                 action: TOGGLE_CURSOR.to_owned(),
-                desc:   "toggle cursor item(add or rm topic_tags, or goto tab1/edit)".to_owned(),
+                desc:   "trigger cursor item, in edit pop menu will active button (add or rm \
+                         topic_tags, or goto tab1/edit)"
+                    .to_owned(),
             },
         ]);
 

crates/lcode/src/app/dispatch/handle_key.rs

@@ -97,14 +97,15 @@ impl<'app_lf> App<'app_lf> {
                 RIGHT => self.edit.horizontal_scroll_l(),
                 TOP => self.edit.vertical_scroll_gg(),
                 BOTTOM => self.edit.vertical_scroll_G(),
-                HEAD => self.edit.pop_head(),
+                HEAD => self.edit.goto_pop_head(),
                 EDIT_IN_TUI => self.edit.start_edit_tui(),
                 EDIT_CODE_EDITOR => self
                     .edit_tab_edit_with_editor()
                     .await
                     .is_ok(),
-                SUBMIT_CODE if self.edit.show_pop_menu => self.submit_code(),
-                TEST_CODE if self.edit.show_pop_menu => self.test_code(),
+
+                TOGGLE_CURSOR if self.edit.show_pop_menu => self.menu_button_trig(),
+
                 TOGGLE_MENU => self.edit.toggle_menu(),
                 TOGGLE_SUBMIT_RES => self.edit.toggle_submit_res(),
                 TOGGLE_TEST_RES => self.edit.toggle_test_res(),