Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save-demo-agents infra improvements #2060

Closed
sanyavertolet opened this issue Mar 31, 2023 · 1 comment · Fixed by #2062
Closed

save-demo-agents infra improvements #2060

sanyavertolet opened this issue Mar 31, 2023 · 1 comment · Fixed by #2062
Assignees
@sanyavertolet
Labels
demo Issues and PRs related to save-demo service infra Issues related to build or deploy infrastructure

Comments

@sanyavertolet
Copy link
Member

sanyavertolet commented Mar 31, 2023 •
edited
Loading

Right now we send request to Kubernetes in order to get save-demo-agent IP, which could be slow. The solution is to create a Service per demo and send requests directly to save-demo-agent. After the task is done it might be a good idea to finally finish and merge #1247.
@sanyavertolet sanyavertolet added infra Issues related to build or deploy infrastructure demo Issues and PRs related to save-demo service labels Mar 31, 2023
@sanyavertolet sanyavertolet self-assigned this Mar 31, 2023
@sanyavertolet
Copy link
Member Author

Done with #2062

@nulls nulls linked a pull request Apr 6, 2023 that will close this issue
save-demo-agents isolation pt I #2062
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanyavertolet sanyavertolet

Labels
demo Issues and PRs related to save-demo service infra Issues related to build or deploy infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

save-demo-agents isolation pt I saveourtool/save-cloud
1 participant
@sanyavertolet