Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shadow artifact for diktat-runner #1878

Open
nulls opened this issue Dec 19, 2023 · 0 comments
Open

Remove shadow artifact for diktat-runner #1878

nulls opened this issue Dec 19, 2023 · 0 comments
Labels
infrastructure Issues related to building the project, CI/CD, deployments etc.
Milestone
2.1.0

Comments

@nulls
Copy link
Member

nulls commented Dec 19, 2023

diktat-runner:shadow was added for spotless.
But Gradle and Maven use different notations for maven coordinate:

  • gradle: com.saveourtool.diktat:diktat-runner:<version>:shadow
  • maven com.saveourtool.diktat:diktat-runner:jar:shadow:<version>

Since Spotless has a common code base for both plugins we can't use the shadow plugin. But the regular dependency should work fine
@nulls nulls added the infrastructure Issues related to building the project, CI/CD, deployments etc. label Dec 19, 2023
@nulls nulls added this to the 2.1.0 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Issues related to building the project, CI/CD, deployments etc.
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@nulls