New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information regarding PhotoEditor #5

Open

trideeprath opened this issue Nov 6, 2020 · 1 comment

trideeprath commented Nov 6, 2020

Can you please provide a little more information about the PhotoEditor edit function algorithms. Like

What exactly does Srgb2Photopro do?
What's the purpose of Sigmoid Inverse and Sigmoid here?
How did you come up with the 12 edit functions. Have you done any ablation study of the impact of each of the 12 functions? If not can you provide any of your intuitions?

Owner

satoshi-kosugi commented Nov 9, 2020

I implemented PhotoEditor to reproduce Adobe Lightroom.

Srgb2Photopro converts the color space of the input image from srgb to Prophoto, which is used in Adobe Lightroom. (Photopro is my typo.)
I use Sigmoid to reproduce the effects of the filters in Adobe Lightroom.
I select 12 edit functions based on the filters in Adobe Lightroom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment