Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to reproduce the results from paper #3

Open
eugene-goncharov opened this issue Jul 5, 2020 · 4 comments
Open

Trying to reproduce the results from paper #3

eugene-goncharov opened this issue Jul 5, 2020 · 4 comments

Comments

@eugene-goncharov
Copy link

Hi,

I'm trying to reproduce the results from paper and the reward never goes above zero.

Could you please let me know if it is possible to reproduce the results with one worker. I'm training on Windows and Chainer is not working on more than one worker.

Many thanks
Eugene

@satoshi-kosugi
Copy link
Owner

I guess you are using unexpected versions of the libraries.
After installing the following versions of the libraries, please try using multiple workers.

  • Python 3.6
  • Chainer 7.0
  • ChainerRL 0.6

@eugene-goncharov
Copy link
Author

I've tried the exact versions of libraries. Using these libraries it is required to do some minor change in the code, because the Chainer API is different.

But anyway, on Windows multiple workers are not working. I'm trying to reproduce the results on Linux. I'll update this issue later today.

@eugene-goncharov
Copy link
Author

I've tried on Linux, after 100k steps the reward still below zero, like -5 or something near.

Should it go above zero? How many steps do you do during training?
Is it possible to share the training curves and discriminator weights?

@satoshi-kosugi
Copy link
Owner

The reward should become larger than at the start of the training but does not need to become larger than zero.

I trained the model for 96000 steps, which is the default value in settings/photo_enhancement.yaml (96000 = 16 processes * 6000 n_update).

To reproduce the paper's results, please try training and testing the model as described in README.md.
That is, to train the model,

python train.py settings/photo_enhancement.yaml logs

and to test the model,

python test.py settings/photo_enhancement.yaml logs --result_dir logs/20200115T223451.986831/96000_finish/test_results --load logs/20200115T223451.986831/96000_finish/

where 20200115T223451.986831 should be replaced with the time when you start the training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants