From 4b0758aba741a89db2f996b27e27b214957d3b10 Mon Sep 17 00:00:00 2001
From: Mircea Roata <mircearoatapalade@gmail.com>
Date: Mon, 21 Aug 2023 15:37:59 +0300
Subject: [PATCH] chore: use GQL TargetName enum

---
 .../components/sml-versions/SMLVersionForm.svelte    | 12 ++++++------
 src/lib/models/sml-versions.ts                       |  4 ++--
 src/lib/models/versions.ts                           |  5 ++++-
 src/lib/utils/formatting.ts                          | 10 ++++++----
 4 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/src/lib/components/sml-versions/SMLVersionForm.svelte b/src/lib/components/sml-versions/SMLVersionForm.svelte
index 02d86107f..8c2d67109 100644
--- a/src/lib/components/sml-versions/SMLVersionForm.svelte
+++ b/src/lib/components/sml-versions/SMLVersionForm.svelte
@@ -8,7 +8,7 @@
   import { smlVersionSchema } from '$lib/models/sml-versions';
   import Textfield from '@smui/textfield';
   import Button from '@smui/button';
-  import { VersionStabilities } from '$lib/generated';
+  import { TargetName, VersionStabilities } from '$lib/generated';
   import Select, { Option } from '@smui/select';
 
   export let onSubmit: (data: SMLVersionData) => void;
@@ -22,7 +22,7 @@
     satisfactory_version: 0,
     stability: VersionStabilities.Alpha,
     version: '',
-    targets: [{ targetName: 'Windows', link: '' }]
+    targets: [{ targetName: TargetName.Windows, link: '' }]
   };
   export let submitText = 'Create';
 
@@ -33,7 +33,7 @@
   });
 
   const addTarget = () => {
-    addField('targets', { targetName: '', link: '' });
+    addField('targets', { targetName: TargetName.Windows, link: '' });
   };
 
   const removeTarget = (i: number) => {
@@ -106,9 +106,9 @@
         <div class="flex content-center gap-2">
           <div>
             <Select bind:value={target.targetName} label="Platform">
-              <Option value="Windows">Windows Client</Option>
-              <Option value="WindowsServer">Windows Server</Option>
-              <Option value="LinuxServer">Linux Server</Option>
+              <Option value={TargetName.Windows}>Windows Client</Option>
+              <Option value={TargetName.WindowsServer}>Windows Server</Option>
+              <Option value={TargetName.LinuxServer}>Linux Server</Option>
               <svelte:fragment slot="helperText">
                 <ValidationMessage for="targets.{i}.targetName" let:messages={message}>
                   <span class="validation-message">{message || ''}</span>
diff --git a/src/lib/models/sml-versions.ts b/src/lib/models/sml-versions.ts
index b80a84057..0fa326da6 100644
--- a/src/lib/models/sml-versions.ts
+++ b/src/lib/models/sml-versions.ts
@@ -1,8 +1,8 @@
 import * as zod from 'zod';
-import type { UpdateSmlVersionTarget, VersionStabilities } from '$lib/generated';
+import type { TargetName, UpdateSmlVersionTarget, VersionStabilities } from '$lib/generated';
 
 export type SMLTargetData = {
-  targetName: string;
+  targetName: TargetName;
   link: string;
 };
 
diff --git a/src/lib/models/versions.ts b/src/lib/models/versions.ts
index 744745b17..32f14e50c 100644
--- a/src/lib/models/versions.ts
+++ b/src/lib/models/versions.ts
@@ -5,6 +5,7 @@ import type { Writable } from 'svelte/store';
 import type { ZodObject, ZodRawShape } from 'zod';
 import type { File } from '$lib/models/file';
 import type { VersionStabilities } from '$lib/generated';
+import { TargetName } from '$lib/generated/graphql';
 
 export type VersionData = {
   file: File;
@@ -25,7 +26,9 @@ export type VersionMetadata = {
   targets: string[];
 };
 
-const ALLOWED_TARGETS = ['Windows', 'WindowsServer', 'LinuxServer'];
+const ALLOWED_TARGETS = Object.keys(TargetName)
+  .map((key) => TargetName[key])
+  .filter((value) => typeof value === 'string') as TargetName[];
 
 const readUPluginJson = async (
   uPluginJson: string,
diff --git a/src/lib/utils/formatting.ts b/src/lib/utils/formatting.ts
index 21db21d3f..d27c9dbf1 100644
--- a/src/lib/utils/formatting.ts
+++ b/src/lib/utils/formatting.ts
@@ -1,3 +1,5 @@
+import { TargetName } from '$lib/generated/graphql';
+
 export const prettyDate = (date: Date | string) => {
   if (typeof date === 'string') {
     date = new Date(date);
@@ -22,13 +24,13 @@ export const prettyBytes = (bytes: number, decimals = 2) => {
   return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
 };
 
-export const prettyTarget = (target: string) => {
+export const prettyTarget = (target: TargetName) => {
   switch (target) {
-    case 'Windows':
+    case TargetName.Windows:
       return 'Windows Client';
-    case 'WindowsServer':
+    case TargetName.WindowsServer:
       return 'Windows Server';
-    case 'LinuxServer':
+    case TargetName.LinuxServer:
       return 'Linux Server';
   }