Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @actions/exec to avoid passing the docker password on the command line #134

Open
domdfcoding opened this issue May 1, 2021 · 0 comments

Comments

@domdfcoding
Copy link

Per the comment in DockerActionBuilder.ts:

// Todo: use stdin
// https://github.com/actions/toolkit/pull/360
// waiting for new release.
await exec.exec('docker login', [
registry,
'-u', user,
'-p', token,
])
}

this depended on actions/toolkit#360, which has been merged. From what I can tell the changes made it into version 1.0.4

Would it be possible to have this updated to use stdin?

Thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant