Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality #25

Open
iskitsas opened this issue Apr 1, 2021 · 7 comments
Open

Search functionality #25

iskitsas opened this issue Apr 1, 2021 · 7 comments
Labels

Comments

@iskitsas
Copy link
Contributor

iskitsas commented Apr 1, 2021

  • Provide a REST API to search resources of CMS
  • Integrate with frontend
@iskitsas iskitsas added the story label Apr 1, 2021
@Sanskar95
Copy link
Contributor

@iskitsas
Would there be only search by name or we can search by multiple attributes of a resource?

@iskitsas
Copy link
Contributor Author

iskitsas commented Apr 6, 2021

Hi @Sanskar95,

I would go with multiple attributes. Another solution would be to integrate ELK stack or SOLR, and build on top of that.

@Sanskar95
Copy link
Contributor

@iskitsas
If we go with elastic search , we would need to migrate the existing data in MySQL to a elastic index right?

@iskitsas
Copy link
Contributor Author

iskitsas commented Apr 8, 2021

@Sanskar95
correct

@Sanskar95
Copy link
Contributor

@iskitsas we can then get started with migration scripts first as part of this story , will create an issue for it.
One suggestion:
Should we create an endpoint for it in the cms application itself or a separate application?

@Sanskar95
Copy link
Contributor

Linked to #26

@iskitsas
Copy link
Contributor Author

iskitsas commented Apr 9, 2021

Hi @Sanskar95 ,
The ELK stack should be on a different container. You should create auxiliary endpoints for triggering actions like re-indexing, update index etc (useful on operations). The backend should support integrations with the ES API, so you should also implement a client for this. This could be a general one, and be easily turned on or off (someone might do not want indexing). Take into account that you could provide an interface for this and easily someone to choose which implementation to use, eg ES vs SOLR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants