Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator should error when invalid variables and mixins are encountered #182

Open
jathak opened this issue Apr 23, 2021 · 0 comments
Open
Labels
enhancement New feature or request module system Part of the module system migrator

Comments

@jathak
Copy link
Member

jathak commented Apr 23, 2021

Right now, if an unrecognized member is encountered during the references pass, it's silently ignored. For functions, this is the best we can do, since the unrecognized function could be a CSS function (or part of a post-processor). However, we should have enough context to error when unrecognized variables and mixins are encountered. This should prevent the migrator from improperly migrating a file that it doesn't have sufficient context for.

@jathak jathak added enhancement New feature or request module system Part of the module system migrator labels Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module system Part of the module system migrator
Projects
None yet
Development

No branches or pull requests

1 participant