Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested api changes #46

Open
asottile opened this issue Feb 5, 2015 · 3 comments
Open

Suggested api changes #46

asottile opened this issue Feb 5, 2015 · 3 comments

Comments

@asottile
Copy link
Member

asottile commented Feb 5, 2015

I think it would simplify the code to expose the following instead of compile:

def compile_string(s, **kwargs):
    # ...

# and

def compile_file(filename, **kwargs):
    # ...

and drop compile_directory (libsass has hard deprecated it)

@dahlia
Copy link
Member

dahlia commented Mar 6, 2015

Seems better, we can change it in 0.8.0 release.

@mgreter
Copy link
Contributor

mgreter commented Dec 15, 2015

Libsass never implemented compile_directory and traces in the API will probably be removed completely. There are some internal refactorings pending which will remove this from the internal C++ API too. Was there anything related to this exposed on the C level? I was under the impression we could safely remove it from libsass.

@asottile
Copy link
Member Author

@mgreter it used to be exposed in the old api, which I removed dependence on here: 202d657#diff-454523db191eb8e24222f01b7d4e7c1dL144

To keep our api compatibility, we have an implementation in pure python: https://github.com/dahlia/libsass-python/blob/599f47019da132008fecb168d272fd814ac85821/sass.py#L198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants