This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
fix: make Qt taurus extensions inherit from base extensions #1691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt taurus extensions do not inherit from the base extensions,
but directly from a TangoDevice (taurus). As a consequence, all
the extended logic is not available. Make the two existing Qt taurus
extension classes (QPool and QMeasurementGroup) inherit from
the base extension classes.
MeasurementGroup (base extension) already implements all
the configuration attribute methods. Remove the duplicated code
and use the base extension implementation.
Strictly speaking, this breaks the compatibility of the
getConfiguration()
method. Before it was returning a dict and nowit returns MGConfiguration object.
I have tested using this script:
I also quickly checked if the expconf is still operational.
Fixes #1688. @kklmn I don't know if you have any possibility to validate if it works for you.
Your eventual feedback here could speed up the integration process.
Many thanks!