You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
The macros edctrlcls and edctrllib are implemented in the macro file expert.py. The code there is now correct
but not complet: the part corresponding to the opening of the editor is not implemented. This should be done
like for edmac and edmaclib, that are actually magic commands implemented in spock/magic.py.
The current implementation of the macros could replace the part specific for the macros in the corresponding
macro commands.
In the macro commands the functions Set/GetMacroCode (implemented in MacroServer.py) are used. Analog
functions could be implemented for the controllers in Pool.py (in fact they are already there but empty). They
will take some of the functionality that is now in edctrlcls and edctrlib.
We have to discuss if this effort is needed/wanted since, according to the results of the Sardana Questionnaire,
it seems that none institute will profit of that.
The text was updated successfully, but these errors were encountered:
Thanks @teresanunez for raising this issue. I think with the results of your investigation during the SBSP2021 and with your fix in #1635 this won't be too much work to make these magic commands.
Coming back to the results of the questionnaire, I think it is normal that the users were not so enthusiastic about adding this feature. IMO it is because the users do not write controllers, they write macros. But, looking at this feature from the perspective of a control engineer, I think that things change a little bit. I think it would be actually quite useful to be able to quickly open the controller code, and make small changes directly in the Spock. What do others think about it?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The macros edctrlcls and edctrllib are implemented in the macro file expert.py. The code there is now correct
but not complet: the part corresponding to the opening of the editor is not implemented. This should be done
like for edmac and edmaclib, that are actually magic commands implemented in spock/magic.py.
The current implementation of the macros could replace the part specific for the macros in the corresponding
macro commands.
In the macro commands the functions Set/GetMacroCode (implemented in MacroServer.py) are used. Analog
functions could be implemented for the controllers in Pool.py (in fact they are already there but empty). They
will take some of the functionality that is now in edctrlcls and edctrlib.
We have to discuss if this effort is needed/wanted since, according to the results of the Sardana Questionnaire,
it seems that none institute will profit of that.
The text was updated successfully, but these errors were encountered: