Support dynamic NAT pools for router in Elektra

[sebageek]

Our asr1k driver now supports adding multiple IPs to the external gateway of a router. This will result in a NAT pool being created in the router config, resulting in a larger NAT pool, which is a feature a couple of customers have requested. We would like this feature to be exposed in Elektra.

From an API perspective this works by providing multiple external_fixed_ips as part of the external_gateway_info. This can be done on router create as well as on router update. From an API perspective "having a Pool" looks no different than "three or more IPs on the external gateway".

Caveats:

• two ips are not possible. either provide one ip or three (two for the pool, one for the router)
• the last IP is always used for the router itself
• all pool ips need to be consecutive (but if only a subnet id is provided the driver autoallocates the pool)

The driver will complain about anything that is not working with a HTTP Bad Request. The description + implementation can be found here in the driver including all new exceptions the driver can throw. Details on the feature can be found in our internal ADR repo or soon in our user docs.

[NicCage1337]

Observation: Once multiple external_fixed_ips are configured via CLI / API the Router object is not properly manageable via Elektra. UI Changes (e.g. subnet attach / dettach) are overwriting the external_fixed_ips and NAT Pooling is removed.

Proposal to fix:

• Block UI Changes if NAT Pooling is configured
• Improve support of multiple external_fixed_ips so that configuration won't be overwritten
• Implement the proposed enhancement for a full support of NAT pooling configuration in Elektra

[edda]

See Slack discussion

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you need to keep this issue open set label of this issue to 'neverstale'. Thank you for your contributions.