Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an ABAP Core Data Services (CDS) View in SAP BTP, ABAP Environment #2537

Open
francisco-milan opened this issue Sep 29, 2024 · 0 comments

Comments

@francisco-milan
Copy link

francisco-milan commented Sep 29, 2024

Tutorials: https://developers.sap.com/tutorials/abap-environment-create-cds-mde.html

Write here how you think we can improve the tutorial ...

Hello,

I wanted to provide some feedback regarding the code in Step 9. I encountered an issue when I copied and pasted the original version; it didn’t work as expected. After some adjustments, I was able to get it functioning correctly.

Original Version:

@UI           : {
lineItem      : [{position: 10, importance: #HIGH}]
}
key TravelID;

@UI           : {
      lineItem      : [{position: 15, importance: #HIGH}]
      }
AgencyID,

@UI           : {
      lineItem      : [{position: 20, importance: #HIGH}]
      }
CustomerID,

@UI           : {
      lineItem      : [{position: 30, importance: #HIGH}]
      }
BeginDate,

@UI           : {
      lineItem      : [{position: 40, importance: #HIGH}]
      }
EndDate,

BookingFee,

@UI           : {
      lineItem      : [{position: 50, importance: #HIGH}]
      }
TotalPrice,

Proposed Version:

@UI           : { 
    lineItem      : [{position: 10, importance: #HIGH}]
}
key TravelID,

@UI           : {
    lineItem      : [{position: 15, importance: #HIGH}]
}
AgencyID,

@UI           : {
    lineItem      : [{position: 20, importance: #HIGH}]
}
CustomerID,

@UI           : {
    lineItem      : [{position: 30, importance: #HIGH}]
}
BeginDate,

@UI           : {
    lineItem      : [{position: 40, importance: #HIGH}]
}
EndDate,

@Semantics.amount.currencyCode: 'CurrencyCode'
BookingFee,

@Semantics.amount.currencyCode: 'CurrencyCode'
@UI           : {
    lineItem      : [{position: 50, importance: #HIGH}]
}
TotalPrice,

Key Differences:
The main differences in my proposed version include the addition of @Semantics.amount.currencyCode: 'CurrencyCode' for both BookingFee and TotalPrice (following the instructions on STEP 3). Additionally, I corrected the semicolon after "key TravelID" to a comma, ensuring proper syntax for the code structure.

I hope this feedback is helpful! Thank you for your efforts in creating this Tutorial.

Best regards,

Francisco Milan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants