Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing state pollution in zones #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing state pollution in zones #356

wants to merge 1 commit into from

Conversation

sturmianseq
Copy link

This PR aims to improve test reliability of test test_pythonic by removing state pollution in python list zones by executing the test code with a deepcopy of zones.

The test can fail in this way if state pollution in zones is not removed:

        zonenames = [zone.Name for zone in zones]
>       assert printout == zonenames
E       AssertionError: assert ['PLENUM-1', ...PACE5-1', ...] == ['PLENUM-1', '...PACE5-1', ...]
E         At index 2 diff: 'SPACE2-1' != 'FIRST-SMALL-ZONE'
E         Full diff:
E         ['PLENUM-1',
E         'SPACE1-1',
E         -  'SPACE2-1',
E         +  'FIRST-SMALL-ZONE',
E         'SPACE3-1',...

@santoshphilip
Copy link
Owner

acknowledging your pull request.
I may take some time to get to this, as I am traveling now.

@sturmianseq
Copy link
Author

No worries! Take your time:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sturmianseq @santoshphilip