Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get into TechEmpower benchmarks #53

Closed
seemethere opened this issue Oct 17, 2016 · 14 comments
Closed

Get into TechEmpower benchmarks #53

seemethere opened this issue Oct 17, 2016 · 14 comments

Comments

@seemethere
Copy link
Member

seemethere commented Oct 17, 2016

I think it'd be useful to have sanic in the TechEmpower benchmarks so that more users can discover it.

The instructions to get in are found here:
https://www.techempower.com/benchmarks/#section=code

And sample applications can be found here:
https://github.com/TechEmpower/FrameworkBenchmarks

@ludovic-gasc
Copy link
Contributor

Hi,

I'm the maintainer of AsyncIO branch of TechEmpower Benchmarks (BTW, you've a typo in the title).
I'm working to integrate sanic in the test suite with multi-worker pattern to be fair with other benchmarks.

Stay tuned, I'll publish a branch when I'll be ready.

Have a nice week.

@seemethere seemethere changed the title Get into TechemPower benchmarks Get into TechEmPower benchmarks Oct 17, 2016
@seemethere seemethere changed the title Get into TechEmPower benchmarks Get into TechEmpower benchmarks Oct 17, 2016
@channelcat
Copy link
Contributor

channelcat commented Oct 18, 2016

@GMLudo awesome! I hope to have multi-worker (using python multiprocessing and loop.create_server with reuse_port) pushed by tonight, so hopefully that saves you time :). The syntax should just be

app.run(host='0.0.0.0.0', port=80, workers=4)

@channelcat
Copy link
Contributor

Just an update - multiprocessing was added with pr #57 and was pushed to pypi as well

@ludovic-gasc
Copy link
Contributor

Hi @channelcat, thanks for the multi-worker implementation.

I've made a first draft: Eyepea/FrameworkBenchmarks@2151722
Interested by your feedbacks.

I need a patch in Sanic to work: Eyepea@7dcdc62
I'm sending a PR for that.

I've did some measures with wrk, it seems unbelievable when I compare with existing benchmark suite, at least on my hardware, congratulations ;-)
However, I don't publish numbers, I prefer to wait that TechEmpower publishes official numbers for the next round.

I hope to finish to integrate the complete test suite, with postgresql, mysql and redis support during the week-end for an official PR to TechEmpower.

Have a nice week.

@ludovic-gasc
Copy link
Contributor

Hi @channelcat,

I don't forget you, but I've several constraints right now. I hope to finish for the end of this week.

@seemethere
Copy link
Member Author

@GMLudo Do we have an update on this?

@ludovic-gasc
Copy link
Contributor

@seemethere I've 500+ e-mails to read but I've made a branch for that.
It should be ok for round 14.

@feluxe
Copy link

feluxe commented Feb 15, 2018

I just saw the benchmarks from 2018 and am a little surprised to find Sanic so far down the list:

https://www.techempower.com/benchmarks/#section=data-r15&hw=ph&test=plaintext

@yunstanford
Copy link
Member

not sure how it hooks up, but sth. is wrong obviously as you can tell from the error count and the number...
https://www.techempower.com/benchmarks/#section=data-r15&hw=ph&test=json shows different.
I'm not sure how the number comes out..

@r0fls
Copy link
Contributor

r0fls commented Feb 16, 2018 via email

@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label May 14, 2019
@stalkerg
Copy link

stalkerg commented Oct 1, 2024

it seems like broken right now, can somebody fix sanic in TechEmpower?

@stalkerg
Copy link

stalkerg commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants