Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: let user specify pure and ambiguous bases #103

Open
arturotorreso opened this issue Mar 30, 2021 · 0 comments
Open

Improvement: let user specify pure and ambiguous bases #103

arturotorreso opened this issue Mar 30, 2021 · 0 comments

Comments

@arturotorreso
Copy link

This is an amazing tool, and I ended up relying quite a lot on it due to its speed!

One improvement I would add is letting the user specify what a "pure base" is and what an "unknown" base is. This feature is inspired by two situations I run into often:

  1. Many times "-" actually symbolizes a proper polymorphism, and for non-phylogenetic analysis users may want to keep them in their snp-aligment.
  2. I often use IUPAC ambiguity codes in my alignments (M,R,W...), and in those positions with REF+IUPAC code, the column will be kept.

I think the change would be relatively easy to implement. I did change the src code (objects "is_unknown" and "is_pure" from alignment-file.c) before compiling it so it's suitable to my needs, but other users may want to benefit from this as well.

@arturotorreso arturotorreso changed the title Consider improvement: let user specify pure and ambiguous bases Improvement: let user specify pure and ambiguous bases Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant