Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional anisotropic scaling parameter upon reading the input mesh file #326

Open
smelchio opened this issue Oct 17, 2019 · 1 comment

Comments

@smelchio
Copy link
Contributor

smelchio commented Oct 17, 2019

In our projects, we are implementing the scaling in the following way:

auto& coords = mesh.coords();
mesh.set_coords(osh::deep_copy(coords)*scale);
coords = mesh.coords();

but it would be nicer to have directly
auto mesh = gmsh::read(filename.c_str(), library.world(), anisotropic_scale)
where in the isotropic case
anisotropic_scale = Few<Real, 3>(scale)

@ibaned
Copy link
Collaborator

ibaned commented Dec 3, 2019

From a design perspective, I don't think this belongs in the mesh reading API. There should be a separate helper function scale(Mesh*, Few<Real, 3>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants