Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark mocha and nyc as optional dependencies #32

Closed
Avaq opened this issue Nov 1, 2019 · 3 comments
Closed

Mark mocha and nyc as optional dependencies #32

Avaq opened this issue Nov 1, 2019 · 3 comments

Comments

@Avaq
Copy link
Member

Avaq commented Nov 1, 2019

A breaking change that makes so users have to manually install mocha and nyc. The reasoning is taken from fluture-js/fluture-template#1 (comment).
@Avaq
Copy link
Member Author

Avaq commented Nov 1, 2019

I'm not sure about this one. With the same reasoning, all dependencies could be marked as optional, because all sanctuary scripts are manually replaceable. That would put the user in a worse position, though, as a bunch of boilerplate is being shoved back onto their plate.

@davidchambers
Copy link
Member

Aldwin, what do you think about this now that #64 has been merged?

@Avaq
Copy link
Member Author

Avaq commented Dec 29, 2023

Happy to close this

@Avaq Avaq closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidchambers @Avaq