Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: replace UIWebView with WKWebView #1270

Closed
Dejal opened this issue Dec 24, 2019 · 5 comments
Closed

iOS: replace UIWebView with WKWebView #1270

Dejal opened this issue Dec 24, 2019 · 5 comments
Labels
critical iOS

Comments

@Dejal
Copy link
Collaborator

Dejal commented Dec 24, 2019

This was mentioned as part of the Mac Catalyst idea (#1247), but now has a fixed deadline, so I'm adding a separate issue for it.

Apple announced on December 23, 2019:

If your app still embeds web content using the deprecated UIWebView API, we strongly encourage you to update to WKWebView as soon as possible for improved security and reliability. WKWebView ensures that compromised web content doesn’t affect the rest of an app by limiting web processing to the app’s web view. And it’s supported in iOS and macOS, and by Mac Catalyst.

The App Store will no longer accept new apps using UIWebView as of April 2020 and app updates using UIWebView as of December 2020.

So we need to complete this within the next year. I'm giving it a critical priority since it has a deadline, and will take some time, though we have several months to complete it.
Dejal added a commit that referenced this issue Feb 23, 2020
@Dejal
#1270 (replacing UIWebView with WKWebView)
383384b 
- All app-specific uses of UIWebView have been replaced with WKWebView.
- Some third-party uses remain.
- More testing required.
- Note that I’ve bumped the minimum iOS version to iOS 11, since that is needed for WKWebView support.
- Committing to a new branch until ready.
@samuelclay
Copy link
Owner

Yep, it's time. Got the warning from Apple today:

Dear Developer,

We identified one or more issues with a recent delivery for your app, "NewsBlur" 10.0.2 (112). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of app updates that use UIWebView APIs starting from December 2020. See https://developer.apple.com/documentation/uikit/uiwebview for more information.

After you’ve corrected the issues, you can upload a new binary to App Store Connect.

Best regards,

The App Store Team

Dejal added a commit that referenced this issue Mar 28, 2020
@Dejal
#1270 (replacing UIWebView with WKWebView)
dfa0eb9 
- Tweaks for Xcoce 11.4.
- Web view fixes.
Dejal added a commit that referenced this issue Mar 28, 2020
@Dejal
#1270 (replacing UIWebView with WKWebView)
0a9e79e 
- Updated 1Password extension.
Dejal added a commit that referenced this issue Mar 29, 2020
@Dejal
#1270 (replacing UIWebView with WKWebView)
6b25a69 
- Replaced NJKWebViewProgress with a WKWebView-compatible progress bar in the Original view.
Dejal added a commit that referenced this issue Mar 29, 2020
@Dejal
#1270 (replacing UIWebView with WKWebView)
d0b70a5 
- Disabled unused web views in AFNetworking and InAppSettingsKit.
@Dejal
Copy link
Collaborator Author

Dejal commented Mar 29, 2020

All UIWebView references have been removed or replaced with WKWebView now. All seems well in my testing.

So feel free to merge this into Master when you're ready.

@Dejal Dejal closed this as completed Mar 29, 2020
@Dejal
Copy link
Collaborator Author

Dejal commented Apr 21, 2020

Unless you have any objections, I'll merge the wkwebkit branch into dejal tomorrow.

@samuelclay
Copy link
Owner

Sounds good to me

@Dejal
Copy link
Collaborator Author

Dejal commented Apr 21, 2020

Done. The wkwebkit branch is no longer needed. You can delete it if you wish.

samuelclay pushed a commit that referenced this issue Jun 16, 2020
@Dejal @samuelclay
#1270 (replacing UIWebView with WKWebView)
a6aeba2 
- All app-specific uses of UIWebView have been replaced with WKWebView.
- Some third-party uses remain.
- More testing required.
- Note that I’ve bumped the minimum iOS version to iOS 11, since that is needed for WKWebView support.
- Committing to a new branch until ready.
samuelclay pushed a commit that referenced this issue Jun 16, 2020
@Dejal @samuelclay
#1270 (replacing UIWebView with WKWebView)
f613f18 
- Tweaks for Xcoce 11.4.
- Web view fixes.
samuelclay pushed a commit that referenced this issue Jun 16, 2020
@Dejal @samuelclay
#1270 (replacing UIWebView with WKWebView)
4fad162 
- Updated 1Password extension.
samuelclay pushed a commit that referenced this issue Jun 16, 2020
@Dejal @samuelclay
#1270 (replacing UIWebView with WKWebView)
130bed8 
- Replaced NJKWebViewProgress with a WKWebView-compatible progress bar in the Original view.
samuelclay pushed a commit that referenced this issue Jun 16, 2020
@Dejal @samuelclay
#1270 (replacing UIWebView with WKWebView)
d4625c5 
- Disabled unused web views in AFNetworking and InAppSettingsKit.
samuelclay added a commit that referenced this issue Jun 16, 2020
@samuelclay
Merge branch 'master' into darkmode
b1215c0 
* master:
  Android v10.0b3.
  #1298 (saved searches)
  #1298 (saved searches)
  #1304 (not restoring state)
  #1306 (status bar during fullscreen)
  #1231 (sharing crash)
  #1309 (theme in story detail view)
  Fixed #1314 (persistent "All Done")
  #1306 (status bar during fullscreen)
  #1294 (move to new folder)
  #1293 (invalid permalink)
  #1306 (status bar during fullscreen)
  #1306 (status bar during fullscreen)
  #1294 (move to new folder)
  #1301 (white flash in dark mode)
  #1270 (replacing UIWebView with WKWebView)
  #1270 (replacing UIWebView with WKWebView)
  #1270 (replacing UIWebView with WKWebView)
  #1270 (replacing UIWebView with WKWebView)
  #1270 (replacing UIWebView with WKWebView)
@samuelclay samuelclay mentioned this issue Jul 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelclay @Dejal